Build for generic simulator device, so no specific device is needed (#45

)

* Build for generic simulator device, so no specific device is needed.
* Disabled real device test due to flakyness of virtual-device-testing-for-ios step.

README.md

@@ -67,7 +67,7 @@ You can also run this step directly with [Bitrise CLI](https://github.com/bitris
 | `project_path` | Xcode Project (`.xcodeproj`) or Workspace (`.xcworkspace`) path.  The input value sets xcodebuild's `-project` or `-workspace` option. | required | `$BITRISE_PROJECT_PATH` |
 | `scheme` | Xcode Scheme name.  The input value sets xcodebuild's `-scheme` option. | required | `$BITRISE_SCHEME` |
 | `configuration` | Xcode Build Configuration.  If not specified, the default Build Configuration will be used.  The input value sets xcodebuild's `-configuration` option. | required | `Debug` |
-| `destination` | Destination specifier describes the device to use as a destination.  The input value sets xcodebuild's `-destination` option. | required | `generic/platform=iOS` |
+| `destination` | Destination specifier describes the device to use as a destination.  Recommended values: - `generic/platform=iOS` to build tests for physical devices - `generic/platform=iOS Simulator` to build tests for Simulators  The input value sets xcodebuild's `-destination` option. | required | `generic/platform=iOS` |
 | `test_plan` | Build tests for a specific Test Plan associated with the Scheme.  Leave this input empty to build all the Test Plans or Test Targets associated with the Scheme.  The input value sets xcodebuild's `-testPlan` option. |  |  |
 | `xcconfig_content` | Build settings to override the project's build settings, using xcodebuild's `-xcconfig` option.  You can't define `-xcconfig` option in `Additional options for the xcodebuild command` if this input is set.  If empty, no setting is changed. When set it can be either: 1.  Existing `.xcconfig` file path.      Example:      `./ios-sample/ios-sample/Configurations/Dev.xcconfig`  2.  The contents of a newly created temporary `.xcconfig` file. (This is the default.)      Build settings must be separated by newline character (`\n`).      Example:     ```     COMPILER_INDEX_STORE_ENABLE = NO     ONLY_ACTIVE_ARCH[config=Debug][sdk=*][arch=*] = YES     ``` |  | `COMPILER_INDEX_STORE_ENABLE = NO` |
 | `xcodebuild_options` | Additional options to be added to the executed xcodebuild command.  Prefer using `Build settings (xcconfig)` input for specifying `-xcconfig` option. You can't use both. |  |  |

e2e/bitrise.yml

@@ -50,7 +50,7 @@ workflows:
     after_run:
     - _run
 
-  test_uitest_api_key_signing:
+  manual_test_uitest_api_key_signing:
     envs:
     - SAMPLE_APP_URL: https://github.com/bitrise-io/sample-apps-fastlane-test.git
     - SAMPLE_APP_BRANCH: master
@@ -198,7 +198,8 @@ workflows:
     - SAMPLE_APP_BRANCH: master
     - BITRISE_PROJECT_PATH: ./BullsEye.xcworkspace
     - BITRISE_SCHEME: BullsEye
-    - DESTINATION: platform=iOS Simulator,name=iPhone 12 Pro Max
+    - DESTINATION: generic/platform=iOS Simulator
+    - DESTINATION_RUN_TEST: platform=iOS Simulator,name=iPhone 12 Pro Max
     - CODE_SIGNING_METHOD: "off"
     before_run:
     - _run
@@ -211,7 +212,8 @@ workflows:
     - SAMPLE_APP_BRANCH: master
     - BITRISE_PROJECT_PATH: ./BullsEye.xcworkspace
     - BITRISE_SCHEME: BullsEye
-    - DESTINATION: platform=iOS Simulator,name=iPhone 12 Pro Max
+    - DESTINATION: generic/platform=iOS Simulator
+    - DESTINATION_RUN_TEST: platform=iOS Simulator,name=iPhone 12 Pro Max
     - CODE_SIGNING_METHOD: "off"
     - TEST_PLAN: UnitTests
     before_run:
@@ -296,7 +298,7 @@ workflows:
     - xcode-test-without-building:
         inputs:
         - xctestrun: $BITRISE_XCTESTRUN_FILE_PATH
-        - destination: $DESTINATION
+        - destination: $DESTINATION_RUN_TEST
 
   _expose_xcode_version:
     steps:

step.yml

@@ -100,6 +100,10 @@ inputs:
     description: |-
       Destination specifier describes the device to use as a destination.
 
+      Recommended values:
+      - `generic/platform=iOS` to build tests for physical devices
+      - `generic/platform=iOS Simulator` to build tests for Simulators
+
       The input value sets xcodebuild's `-destination` option.
     is_required: true