Use app specific password from Apple ID connection (#73)

* Update appleauth package

* Update step.yml

* Cover no app-specific password provided for Apple ID connection case

* Update step.yml

* Remove unused auth-test-apple-id-connection-without-app-specific-password

bitrise.yml

@@ -86,7 +86,6 @@ workflows:
         - work_dir: ./
         - verbose_log: "yes"
         - connection: apple_id
-        - app_password: $APP_SPECIFIC_PASSWORD
 
   auth-test-apple-id-connection-globally-set-app-specific-password:
     envs:
@@ -101,7 +100,7 @@ workflows:
         - verbose_log: "yes"
         - connection: apple_id
         - app_password: ""
-
+        
   auth-test-api-key-connection:
     before_run:
     - _auth_prepare

go.mod

@@ -11,7 +11,7 @@ require (
 	github.com/bitrise-io/go-utils v0.0.0-20201211082830-859032e9adf0
 	github.com/bitrise-io/stepman v0.0.0-20190813144014-10564a4888a6 // indirect
 	github.com/bitrise-steplib/bitrise-step-android-unit-test v0.0.0-20190902203028-ff8e682d8645
-	github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210209134909-4d779ddbe073
+	github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210225084122-4a4d9384c633
 	github.com/google/go-cmp v0.5.4 // indirect
 	github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
 	github.com/kr/pretty v0.1.0 // indirect

go.sum

@@ -14,12 +14,16 @@ github.com/bitrise-io/stepman v0.0.0-20190813144014-10564a4888a6 h1:/GnB2kEaO/6K
 github.com/bitrise-io/stepman v0.0.0-20190813144014-10564a4888a6/go.mod h1:hGCjd8leP411yt5QkQi+VBNWGxIZ4H02LNIVeKBeMUk=
 github.com/bitrise-steplib/bitrise-step-android-unit-test v0.0.0-20190902203028-ff8e682d8645 h1:9molXzIAxnKStwV78lt7MSgUQwxIWl4+r9/oYTQA7no=
 github.com/bitrise-steplib/bitrise-step-android-unit-test v0.0.0-20190902203028-ff8e682d8645/go.mod h1:0yqqJw+MqwsfHKq4pL90IoSYskLF91oDCyyZYnIehWA=
+github.com/bitrise-steplib/bitrise-step-export-universal-apk v0.0.0-20200729103519-a582681d23d6 h1:7UWHsApY8/iIGw1jVbDiL3FMnI70Y/t0BxG9nQupHhI=
+github.com/bitrise-steplib/bitrise-step-export-universal-apk v0.0.0-20200729103519-a582681d23d6/go.mod h1:WBGpmu+FXynGkpED0re/InExsBaRG7Y2tMabxnFgSuA=
 github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210204114640-c91fdc7c90cd h1:ieyOJ5xYu0nxVf9dpyRCg3RgS/Uhc3hfNBI6RUWms/Q=
 github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210204114640-c91fdc7c90cd/go.mod h1:mG5kKjSyK3sZNp7e5QpFBAtxJRWeA+4PSMh3ZfwggNs=
 github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210209130532-8386805c9389 h1:NQfjDuwNE/LhjTkMV7+PmRE/c+KFPxXJTZeW6TfEptY=
 github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210209130532-8386805c9389/go.mod h1:mG5kKjSyK3sZNp7e5QpFBAtxJRWeA+4PSMh3ZfwggNs=
 github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210209134909-4d779ddbe073 h1:348wxtooA7rjIe0pXLJwVPwddrURmq+6hCWcfE6hACQ=
 github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210209134909-4d779ddbe073/go.mod h1:mG5kKjSyK3sZNp7e5QpFBAtxJRWeA+4PSMh3ZfwggNs=
+github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210225084122-4a4d9384c633 h1:6Rw2tRuYzY5baiyAWDhX+psWihsOCZRX2TqtfHzq8TU=
+github.com/bitrise-steplib/steps-deploy-to-itunesconnect-deliver v0.0.0-20210225084122-4a4d9384c633/go.mod h1:+XuCsvAc2xcQpdVnCmQC4Ej+jMc0n60oTtg0oz/BkC4=
 github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=

step.yml

@@ -68,7 +68,7 @@ inputs:
         There are two types of Apple Developer connection you can enable on Bitrise: one is based on an API key of the App Store Connect API, the other is the session-based authentication with an Apple ID. You can choose which type of Bitrise Apple Developer connection to use or you can tell the Step to only use the Step inputs for authentication:
         - `automatic`: Use any enabled Apple Developer connection, either based on Apple ID authentication or API key authentication.  Step inputs are only used as a fallback. API key authentication has priority over Apple ID authentication in both cases.
         - `api_key`: Use the Apple Developer connection based on API key authentication. Authentication-related Step inputs are ignored.
-        - `apple_id`: Use the Apple Developer connection based on Apple ID authentication and **Application-specific password** Step input. Other authentication-related Step inputs are ignored.
+        - `apple_id`: Use the Apple Developer connection based on Apple ID authentication and the **Application-specific password** Step input. Other authentication-related Step inputs are ignored.
         - `off`: Do not use any already configured Apple Developer Connection. Only authentication-related Step inputs are considered.
       is_required: true
       value_options:
@@ -108,9 +108,10 @@ inputs:
   - app_password: ""
     opts:
       title: "Apple ID: Application-specific password"
-      summary: Required if using Apple ID
+      summary: Optional if using two-factor enabled Apple ID.
       description: |-
-        An application-specific password for the Apple ID.
+        Use this input if TFA is enabled on the Apple ID but no app-specific password has been added to the used Bitrise Apple ID connection.
+        
         **NOTE:** Application-specific passwords can be created on the
         [AppleID Website](https://appleid.apple.com). It can be used to
         bypass two-factor authentication.