Skip to content

Commit

Permalink
Sensitive inputs (#5)
Browse files Browse the repository at this point in the history
* Why this change is being made

feat(step.yml): Specify is_sensitive flag for the sensitive inputs in step.yml.
docs(readme): How to trigger a new release.
refactor(bitrise.yml): Removed the old release workflows.
refactor(release_config.yml): Removed the release_config.yml.

Provide links or keys to any relevant tickets, articles or other resources

# --- COMMIT END ---
# Type can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    docs     (changes to documentation)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating grunt tasks etc; no production code change)

* docs(template added): Pull request template added
  • Loading branch information
BirmacherAkos authored and godrei committed Aug 30, 2018
1 parent c89b4fc commit 55c0415
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 64 deletions.
16 changes: 16 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

# Click Up ticket / Github Issue / Discuss Thread

If you have please include the ID / URL of the thread.

## Type of change

Please select options that are relevant.

- [ ] Issue
- [ ] Enhancement
- [ ] Maintenance
- [ ] Feture request
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,9 @@ You can share your Step or step version with the [bitrise CLI](https://github.co
1. Then run: `bitrise run share-this-step` to share the step (version) you specified in the `envs`
1. Send the Pull Request, as described in the logs of `bitrise run share-this-step`

That's all ;)
That's all ;)

## Trigger a new release

- __merge every code changes__ to the `master` branch
- __push the new version tag__ to the `master` branch
48 changes: 0 additions & 48 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,51 +35,3 @@ workflows:
#!/usr/bin/env bash
set -ex
stepman audit --step-yml ./step.yml
# ----------------------------------------------------------------
# --- workflows to create Release
create-release:
steps:
- script:
title:
inputs:
- content: |
#!/usr/bin/env bash
set -e
export CI=true
releaseman create --version $BITRISE_STEP_VERSION
share-this-step:
envs:
# if you want to share this step into a StepLib
- MY_STEPLIB_REPO_FORK_GIT_URL: $MY_STEPLIB_REPO_FORK_GIT_URL
- BITRISE_STEP_ID: $BITRISE_STEP_ID
- BITRISE_STEP_VERSION: $BITRISE_STEP_VERSION
- BITRISE_STEP_GIT_CLONE_URL: $BITRISE_STEP_GIT_CLONE_URL
description: |-
If this is the first time you try to share a Step you should
first call: $ bitrise share
This will print you a guide, and information about how Step sharing
works. Please read it at least once!
As noted in the Step sharing guide you'll have to fork the
StepLib you want to share this step into. Once you're done with forking
the repository you should set your own fork's git clone URL
in the `.bitrise.secrets.yml` file, or here in the `envs` section,
as the value of the `MY_STEPLIB_REPO_FORK_GIT_URL` environment.
You're now ready to share this Step, just make sure that
the `BITRISE_STEP_ID` and `BITRISE_STEP_VERSION`
environments are set to the desired values!
To share this Step into a StepLib you can just run: $ bitrise run share-this-step
Once it finishes the only thing left is to actually create a Pull Request,
the way described in the guide printed at the end of the process.
before_run:
- audit-this-step
steps:
- script:
inputs:
- content: |-
#!/usr/bin/env bash
set -ex
bitrise share start -c "${MY_STEPLIB_REPO_FORK_GIT_URL}"
bitrise share create --stepid "${BITRISE_STEP_ID}" --tag "${BITRISE_STEP_VERSION}" --git "${BITRISE_STEP_GIT_CLONE_URL}"
bitrise share finish
12 changes: 0 additions & 12 deletions release_config.yml

This file was deleted.

5 changes: 2 additions & 3 deletions step.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ description: "Starts the given workflows in the same app"
website: https://github.com/bitrise-steplib/bitrise-step-build-router-start
source_code_url: https://github.com/bitrise-steplib/bitrise-step-build-router-start
support_url: https://github.com/bitrise-steplib/bitrise-step-build-router-start/issues
host_os_tags:
- osx-10.10
- ubuntu-16.04

type_tags:
- utility
Expand All @@ -29,6 +26,8 @@ inputs:
To acquire a `Personal Access Token` for your user, sign in with that user on [bitrise.io](https://bitrise.io),
go to your `Account Settings` page, and select the [Security tab](https://www.bitrise.io/me/profile#/security) on the left side.
is_required: true
is_expand: true
is_sensitive: true
- workflows:
opts:
title: Workflows
Expand Down

0 comments on commit 55c0415

Please sign in to comment.