more loglevel info

[markhu]

adds log.Info to address issue #151

[codecov-io]

Codecov Report

Merging #152 into master will increase coverage by 0.15%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   36.16%   36.32%   +0.15%     
==========================================
  Files          10       10              
  Lines         683      680       -3     
==========================================
  Hits          247      247              
+ Misses        397      394       -3     
  Partials       39       39

Impacted Files	Coverage Δ
cli/add.go	17.55% <0%> (+0.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c709c2...0a99bc1. Read the comment docs.

[godrei]

i would prefer to notify the user with a single line of message, like:

log.Infof("[ENVMAN] added %s: %s", key, value)

[viktorbenei]

Awesome idea @markhu ! Don't forget to address @godrei 's change request ;)

[markhu]

A single log line.

[markhu]

Done.

[trapacska]

Hey @markhu 👋

Just dig myself into this change and I have couple of concerns about it.

• When you export a key:value pair for example bash, you won't have confirmation message about the successful state, could you please describe why is it required to be printed at info log level?
• In the add subcommand we don't print anything at info level, having a new log level type wired in the add subcommand would mean a breaking change for those who rely on the log to be empty in case of success.
• It can also cause multiple security issues as well, in couple of cases users are exporting their secret values into ENVs by envman, exposing these values are not acceptable in the default log level(which is info), it should take separated action to log these out. (I suggest it to be a debug log type)

Thanks for your response!
🚀

[markhu]

The info log level is not normally visible. So the default behavior addresses all your concerns.

[trapacska]

The default log level is info. 🙂

[trapacska]

@markhu So could you please move this log into a higher log level?

[trapacska]

Hey @markhu !

Closing the issue as we didn't receive response about the review. Feel free to re-open or contact us any time of you want to move forward with it! 🙂

Happy Building! 🚀