-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cseda/upload to sauce labs 0.0.1 #4156
base: master
Are you sure you want to change the base?
Cseda/upload to sauce labs 0.0.1 #4156
Conversation
Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.
|
|
||
deps: | ||
brew: | ||
- name: git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the git
cli tool a dependency of this step? By looking at the source code git
command isn't invoked directly.
Hi @camseda thanks for the new Step, I left one comment please have a look. Also to clarify: we have another SauceLabs-related step: https://github.com/bitrise-io/bitrise-steplib/blob/master/steps/saucelabs-espresso-app-automate/0.1.6/step.yml, the difference between the two is that the linked one works with Android APK files and also triggers SuceLab to run Espresso test, while this Step just uploads app artifacts, right? |
@godrei That's correct. The We also have an internal PR up to resolve your comment and will tag you in the new |
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.
bitrise run test
(in the step's repository)bitrise run audit-this-step
(in the step's repository - note, if you don't have this workflow in yourbitrise.yml
, you can copy it from the step template.)New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.