Expo scanner merged with RN scanner (#150)

* expo scanner in progress

* expo scanner migrated

* expo scanner removed and some refactoring

* log fixes

* rn scanner fixes, test updates

* merge fix

* pr update

* turn off icon detection

_tests/integration/reactnative_expo_test.go

@@ -76,7 +76,7 @@ var bitriseCRNAVersions = []interface{}{
 }
 
 var bitriseCRNAResultYML = fmt.Sprintf(`options:
-  react-native-expo:
+  react-native:
     title: Project (or Workspace) path
     env_key: BITRISE_PROJECT_PATH
     value_map:
@@ -149,11 +149,11 @@ var bitriseCRNAResultYML = fmt.Sprintf(`options:
                               Release:
                                 config: react-native-expo-config
 configs:
-  react-native-expo:
+  react-native:
     react-native-expo-config: |
       format_version: "%s"
       default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git
-      project_type: react-native-expo
+      project_type: react-native
       trigger_map:
       - push_branch: '*'
         workflow: primary
@@ -221,7 +221,7 @@ configs:
               - xcodebuild_options: -UseModernBuildSystem=NO
           - deploy-to-bitrise-io@%s: {}
 warnings:
-  react-native-expo: []
+  react-native: []
 `, bitriseCRNAVersions...)
 
 var bitriseExpoKitVersions = []interface{}{
@@ -248,7 +248,7 @@ var bitriseExpoKitVersions = []interface{}{
 }
 
 var bitriseExpoKitResultYML = fmt.Sprintf(`options:
-  react-native-expo:
+  react-native:
     title: Project (or Workspace) path
     env_key: BITRISE_PROJECT_PATH
     value_map:
@@ -353,11 +353,11 @@ var bitriseExpoKitResultYML = fmt.Sprintf(`options:
                                       _:
                                         config: react-native-expo-config
 configs:
-  react-native-expo:
+  react-native:
     react-native-expo-config: |
       format_version: "%s"
       default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git
-      project_type: react-native-expo
+      project_type: react-native
       trigger_map:
       - push_branch: '*'
         workflow: primary
@@ -442,5 +442,5 @@ configs:
               - command: test
           - deploy-to-bitrise-io@%s: {}
 warnings:
-  react-native-expo: []
+  react-native: []
 `, bitriseExpoKitVersions...)

_tests/integration/reactnative_test.go

@@ -134,6 +134,35 @@ configs:
         workflow: primary
       workflows:
         deploy:
+          description: "## Configure Android part of the deploy workflow\n\nTo generate
+            a signed APK:\n\n1. Open the **Workflow** tab of your project on Bitrise.io\n1.
+            Add **Sign APK step right after Android Build step**\n1. Click on **Code Signing**
+            tab\n1. Find the **ANDROID KEYSTORE FILE** section\n1. Click or drop your file
+            on the upload file field\n1. Fill the displayed 3 input fields:\n1. **Keystore
+            password**\n1. **Keystore alias**\n1. **Private key password**\n1. Click on
+            **[Save metadata]** button\n\nThat's it! From now on, **Sign APK** step will
+            receive your uploaded files.\n\n## Configure iOS part of the deploy workflow\n\nTo
+            generate IPA:\n\n1. Open the **Workflow** tab of your project on Bitrise.io\n1.
+            Click on **Code Signing** tab\n1. Find the **PROVISIONING PROFILE** section\n1.
+            Click or drop your file on the upload file field\n1. Find the **CODE SIGNING
+            IDENTITY** section\n1. Click or drop your file on the upload file field\n1.
+            Click on **Workflows** tab\n1. Select deploy workflow\n1. Select **Xcode Archive
+            & Export for iOS** step\n1. Open **Force Build Settings** input group\n1. Specify
+            codesign settings\nSet **Force code signing with Development Team**, **Force
+            code signing with Code Signing Identity**  \nand **Force code signing with Provisioning
+            Profile** inputs regarding to the uploaded codesigning files\n1. Specify manual
+            codesign style\nIf the codesigning files, are generated manually on the Apple
+            Developer Portal,  \nyou need to explicitly specify to use manual coedsign settings
+            \ \n(as ejected rn projects have xcode managed codesigning turned on).  \nTo
+            do so, add 'CODE_SIGN_STYLE=\"Manual\"' to 'Additional options for xcodebuild
+            call' input\n\n## To run this workflow\n\nIf you want to run this workflow manually:\n\n1.
+            Open the app's build list page\n2. Click on **[Start/Schedule a Build]** button\n3.
+            Select **deploy** in **Workflow** dropdown input\n4. Click **[Start Build]**
+            button\n\nOr if you need this workflow to be started by a GIT event:\n\n1. Click
+            on **Triggers** tab\n2. Setup your desired event (push/tag/pull) and select
+            **deploy** workflow\n3. Click on **[Done]** and then **[Save]** buttons\n\nThe
+            next change in your repository that matches any of your trigger map event will
+            start **deploy** workflow.\n"
           steps:
           - activate-ssh-key@%s:
               run_if: '{{getenv "SSH_RSA_PRIVATE_KEY" | ne ""}}'
@@ -257,6 +286,35 @@ configs:
         workflow: primary
       workflows:
         deploy:
+          description: "## Configure Android part of the deploy workflow\n\nTo generate
+            a signed APK:\n\n1. Open the **Workflow** tab of your project on Bitrise.io\n1.
+            Add **Sign APK step right after Android Build step**\n1. Click on **Code Signing**
+            tab\n1. Find the **ANDROID KEYSTORE FILE** section\n1. Click or drop your file
+            on the upload file field\n1. Fill the displayed 3 input fields:\n1. **Keystore
+            password**\n1. **Keystore alias**\n1. **Private key password**\n1. Click on
+            **[Save metadata]** button\n\nThat's it! From now on, **Sign APK** step will
+            receive your uploaded files.\n\n## Configure iOS part of the deploy workflow\n\nTo
+            generate IPA:\n\n1. Open the **Workflow** tab of your project on Bitrise.io\n1.
+            Click on **Code Signing** tab\n1. Find the **PROVISIONING PROFILE** section\n1.
+            Click or drop your file on the upload file field\n1. Find the **CODE SIGNING
+            IDENTITY** section\n1. Click or drop your file on the upload file field\n1.
+            Click on **Workflows** tab\n1. Select deploy workflow\n1. Select **Xcode Archive
+            & Export for iOS** step\n1. Open **Force Build Settings** input group\n1. Specify
+            codesign settings\nSet **Force code signing with Development Team**, **Force
+            code signing with Code Signing Identity**  \nand **Force code signing with Provisioning
+            Profile** inputs regarding to the uploaded codesigning files\n1. Specify manual
+            codesign style\nIf the codesigning files, are generated manually on the Apple
+            Developer Portal,  \nyou need to explicitly specify to use manual coedsign settings
+            \ \n(as ejected rn projects have xcode managed codesigning turned on).  \nTo
+            do so, add 'CODE_SIGN_STYLE=\"Manual\"' to 'Additional options for xcodebuild
+            call' input\n\n## To run this workflow\n\nIf you want to run this workflow manually:\n\n1.
+            Open the app's build list page\n2. Click on **[Start/Schedule a Build]** button\n3.
+            Select **deploy** in **Workflow** dropdown input\n4. Click **[Start Build]**
+            button\n\nOr if you need this workflow to be started by a GIT event:\n\n1. Click
+            on **Triggers** tab\n2. Setup your desired event (push/tag/pull) and select
+            **deploy** workflow\n3. Click on **[Done]** and then **[Save]** buttons\n\nThe
+            next change in your repository that matches any of your trigger map event will
+            start **deploy** workflow.\n"
           steps:
           - activate-ssh-key@%s:
               run_if: '{{getenv "SSH_RSA_PRIVATE_KEY" | ne ""}}'

scanners/flutter/flutter.go

@@ -86,6 +86,7 @@ func findProjectLocations(searchDir string) ([]string, error) {
 
 	filters := []utility.FilterFunc{
 		utility.BaseFilter("pubspec.yaml", true),
+		utility.ComponentFilter("node_modules", false),
 	}
 
 	paths, err := utility.FilterPaths(fileList, filters...)

scanners/reactnative/const.go

@@ -0,0 +1,59 @@
+package reactnative
+
+const deployWorkflowDescription = `## Configure Android part of the deploy workflow
+
+To generate a signed APK:
+
+1. Open the **Workflow** tab of your project on Bitrise.io
+1. Add **Sign APK step right after Android Build step**
+1. Click on **Code Signing** tab
+1. Find the **ANDROID KEYSTORE FILE** section
+1. Click or drop your file on the upload file field
+1. Fill the displayed 3 input fields:
+1. **Keystore password**
+1. **Keystore alias**
+1. **Private key password**
+1. Click on **[Save metadata]** button
+
+That's it! From now on, **Sign APK** step will receive your uploaded files.
+
+## Configure iOS part of the deploy workflow
+
+To generate IPA:
+
+1. Open the **Workflow** tab of your project on Bitrise.io
+1. Click on **Code Signing** tab
+1. Find the **PROVISIONING PROFILE** section
+1. Click or drop your file on the upload file field
+1. Find the **CODE SIGNING IDENTITY** section
+1. Click or drop your file on the upload file field
+1. Click on **Workflows** tab
+1. Select deploy workflow
+1. Select **Xcode Archive & Export for iOS** step
+1. Open **Force Build Settings** input group
+1. Specify codesign settings
+Set **Force code signing with Development Team**, **Force code signing with Code Signing Identity**  
+and **Force code signing with Provisioning Profile** inputs regarding to the uploaded codesigning files
+1. Specify manual codesign style
+If the codesigning files, are generated manually on the Apple Developer Portal,  
+you need to explicitly specify to use manual coedsign settings  
+(as ejected rn projects have xcode managed codesigning turned on).  
+To do so, add 'CODE_SIGN_STYLE="Manual"' to 'Additional options for xcodebuild call' input
+
+## To run this workflow
+
+If you want to run this workflow manually:
+
+1. Open the app's build list page
+2. Click on **[Start/Schedule a Build]** button
+3. Select **deploy** in **Workflow** dropdown input
+4. Click **[Start Build]** button
+
+Or if you need this workflow to be started by a GIT event:
+
+1. Click on **Triggers** tab
+2. Setup your desired event (push/tag/pull) and select **deploy** workflow
+3. Click on **[Done]** and then **[Save]** buttons
+
+The next change in your repository that matches any of your trigger map event will start **deploy** workflow.
+`