Optimized secp256k1 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses optimized c secp256k1 library Node.js addon - Browserified version continues to use elliptic.js
- Includes commands to build and release browser builds - Commands to run node and browser tests with karma
xcthulhu
force-pushed
the
optimized-secp256k1
branch
from
7b02926 to
203c458
Compare
|
Thanks for adding the vectors! |
|
ACK |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked this against my JVM implementation and both implementations can verify each other's signatures.
I have added tests to verify signatures from both implementations here.
I see no more outstanding issues; it would be great if we could merge this since I have upstream stuff that depends on this.
This closes #42, #43, #44, #46, and #47