Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add todo comments for segwit migration #60

Closed
wants to merge 38 commits into from
Closed

Conversation

tkclough
Copy link
Contributor

@tkclough tkclough commented Mar 6, 2018

closes #59

Just added some comments. I'm sure some of them are incorrect (e.g. some of the comments suggesting changing getAddress() to getNestedAddress()), but I figured better to mark them anyway.

@ghost ghost assigned tkclough Mar 6, 2018
@ghost ghost added the in progress label Mar 6, 2018
@tkclough tkclough requested a review from colatkinson March 6, 2018 20:09
@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #60 into master will decrease coverage by 1.69%.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #60     +/-   ##
=========================================
- Coverage   98.82%   97.13%   -1.7%     
=========================================
  Files           6        6             
  Lines         427      453     +26     
  Branches       65       81     +16     
=========================================
+ Hits          422      440     +18     
- Misses          5       10      +5     
- Partials        0        3      +3
Impacted Files Coverage Δ
lib/net.ts 100% <100%> (+0.98%) ⬆️
lib/verify.ts 100% <100%> (ø) ⬆️
lib/txs.ts 93.22% <52.94%> (-4.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2216b8...6b1c9a7. Read the comment docs.

@ghost ghost assigned yongabyte Mar 20, 2018
@ghost ghost removed the in progress label Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locate code to be changed for segwit migration
3 participants