Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seek preview thumbnails exceeding UI dimensions #661

Merged
merged 11 commits into from
Dec 20, 2024

Adjust invocation to match

6257705
Select commit
Loading
Failed to load commit list.
Merged

Fix seek preview thumbnails exceeding UI dimensions #661

Adjust invocation to match
6257705
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 20, 2024 in 0s

1 / 1 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
set the seekPreview position inside of the label, and pass the value in px (instead of %) Incomplete
check if the seekprevew label overflows the UI, and if so, limit its movement Incomplete
add a padding around the seekbarlabel wrapper, to keep the thumbnail a certain distance from the UI edges Incomplete
use span element instead of ::after for caret. This was required to "fix" the caret position to the cursor Incomplete
CHANGELOG entry Completed