Add new advertising UI layout #660
Conversation
| } | ||
|
|
||
| .#{$prefix}-ui-button-ad-skip { |
There was a problem hiding this comment.
The styling for the ad-skip-button was extracted into a separate file.
| // Reset the currentTimeSeekBar and set the position to 0 if the player has no duration | ||
| if (this.player.getDuration() === 0) { | ||
| this.setPlaybackPosition(0); | ||
| currentTimeSeekBar = 0; | ||
| return; | ||
| } |
There was a problem hiding this comment.
This was no problem before as there was no seekbar visible during ad playback.
|
|
||
| .#{$prefix}-label { | ||
| display: inline-block; | ||
| color: $color-ads; |
There was a problem hiding this comment.
TBH i find the yellow text hard to read, are we sure we want to stick with that yellow?
There was a problem hiding this comment.
Noted. I'll take that feedback back to the design process.
There was a problem hiding this comment.
Don't your eyes hurt when looking at the above screenshot and trying to figure out how may seconds there are left until skip?
That bothers me since 6 1/2 years 😄 Is also there on development so nothing new. I'll note that and maybe revisit this if time allows.
|
Description
This PR adds the new UI layout for Ad playback according to the current design. The UI looks the same for small screen and default.
Checklist (for PR submitter and reviewers)
CHANGELOGentry A general entry will be added at the end