Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor small screen layout improvements #659

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

stonko1994
Copy link
Collaborator

Description

Improving the new UI layout for mobile screen.

Changes

  • The SettingsPanel now fills the full width when the screen size is smaller than 400px
  • Add a drop shadow to the SettingsPanel
  • Remove the tap highlight color for WebKit browsers

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry A general entry will be added at the end

.#{$prefix}-ui-uicontainer {
&.#{$prefix}-ui-uicontainer {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This went unnoticed as some of the general styles are handled by the player itself.

@@ -1,12 +1,7 @@
@import '../variables';
@import '../mixins';

// sass-lint:disable no-vendor-prefixes
%opacity-transition {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup.

@stonko1994 stonko1994 changed the title Feature/improve mobile layout Minor mobile layout improvements Dec 12, 2024
@stonko1994 stonko1994 changed the title Minor mobile layout improvements Minor small screen layout improvements Dec 12, 2024
Base automatically changed from feature/super-modern-subtitle-settings-panel to feature/modern-ui-base December 20, 2024 07:55
@stonko1994 stonko1994 merged commit cbd3f61 into feature/modern-ui-base Dec 20, 2024
3 checks passed
@stonko1994 stonko1994 deleted the feature/improve-mobile-layout branch December 20, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants