-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor small screen layout improvements #659
Merged
stonko1994
merged 10 commits into
feature/modern-ui-base
from
feature/improve-mobile-layout
Dec 20, 2024
Merged
Minor small screen layout improvements #659
stonko1994
merged 10 commits into
feature/modern-ui-base
from
feature/improve-mobile-layout
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/improve-mobile-layout
stonko1994
commented
Dec 11, 2024
.#{$prefix}-ui-uicontainer { | ||
&.#{$prefix}-ui-uicontainer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This went unnoticed as some of the general styles are handled by the player itself.
stonko1994
commented
Dec 11, 2024
@@ -1,12 +1,7 @@ | |||
@import '../variables'; | |||
@import '../mixins'; | |||
|
|||
// sass-lint:disable no-vendor-prefixes | |||
%opacity-transition { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup.
stonko1994
changed the title
Feature/improve mobile layout
Minor mobile layout improvements
Dec 12, 2024
stonko1994
changed the title
Minor mobile layout improvements
Minor small screen layout improvements
Dec 12, 2024
wasp898
approved these changes
Dec 12, 2024
Base automatically changed from
feature/super-modern-subtitle-settings-panel
to
feature/modern-ui-base
December 20, 2024 07:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving the new UI layout for mobile screen.
Changes
SettingsPanel
now fills the full width when the screen size is smaller than 400pxSettingsPanel
Checklist (for PR submitter and reviewers)
CHANGELOG
entry A general entry will be added at the end