Improve Seekbar mouse handling #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
force-pushed
the
feature/improve-seekbar-interaction
branch
from
ef2ce06 to
0f1d5ec
Compare
stonko1994
commented
Dec 10, 2024
| cursor: pointer; | ||
| font-size: 1em; | ||
| height: $seekbar-height; | ||
| margin: calc((1em - $seekbar-height) / 2) 0; | ||
| overflow: hidden; |
There was a problem hiding this comment.
Having the overflow hidden here breaks the playback position marker as it is bigger than this container. As a workaround initially we rendered the position marker outside of the seekbar and added the mouse handler to the container as well. This breaks some other UX functionalities. See details in the PR description.
Base automatically changed from
feature/super-modern-ui-for-web
to
feature/modern-ui-base
December 11, 2024 16:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert Seekbar to its current state on development and apply new style by adding a new container element for all bars.
Problem
Currently, the mouse interactions are bound to the container element of the seekbar. This comes with a problem that the mouse events are also applied to the
SeekbarLabel, which should not be the case. Also, the hitbox for seeking becomes smaller and the playback position marker no longer acts as a seeking handle.Changes
To fix this problem while keeping the new design approach, I added another container around all 'bars' inside the seekbar. Therefore the mouse events can stay where they are and this new container can be used for the new styling (mainly for the rounded corners)
Checklist (for PR submitter and reviewers)
CHANGELOGentry A general entry will be added at the end