Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 UI 🚀 #656

Draft
wants to merge 178 commits into
base: develop
Choose a base branch
from
Draft

v4 UI 🚀 #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
178 commits
Select commit Hold shift + click to select a range
aedad47
Feature/prepare new skin (#1)
alesmaye Jul 11, 2024
83cce5d
review fixes
alesmaye Jul 11, 2024
a308660
Merge pull request #632 from alesmaye/feature/modern-mobile-ui-base
alesmaye Jul 11, 2024
b630eb6
build the structure of the new mobile ui with the old ui components
alesmaye Jul 11, 2024
57a8056
deleted 2 comments and fixed code style
alesmaye Jul 12, 2024
f8dfce2
removed watermark
alesmaye Jul 12, 2024
1968989
fixed code style again
alesmaye Jul 12, 2024
c2f082d
Merge pull request #633 from bitmovin/feature/mobile-ui-container
alesmaye Jul 12, 2024
3c69abf
created the subtitletogglebutton
alesmaye Jul 15, 2024
3e07ac5
some code style changes
alesmaye Jul 15, 2024
ffbc038
hide togglebutton if no subtitles are available
alesmaye Jul 15, 2024
50aa7f1
code style
alesmaye Jul 15, 2024
8b64adb
correction
alesmaye Jul 15, 2024
173e0f6
stored language is now a object with the "active" and the "language" …
alesmaye Jul 16, 2024
081608c
linter fixes
alesmaye Jul 16, 2024
f0f2939
linter fixes again
alesmaye Jul 16, 2024
14999d0
review correction
alesmaye Jul 16, 2024
58b249d
review fixes
alesmaye Jul 16, 2024
91a2888
copied css classes from existing ui
alesmaye Jul 16, 2024
687b3bf
Merge pull request #634 from bitmovin/feature/subtitle-toggle-button
alesmaye Jul 17, 2024
f8deb26
changed some icons to the available new ones
alesmaye Jul 17, 2024
b3ab358
menu css now existing
alesmaye Jul 22, 2024
9155c7d
fixed css bugs
alesmaye Jul 23, 2024
de5714c
lint fixes
alesmaye Jul 23, 2024
00e9686
linter
alesmaye Jul 23, 2024
fa5b6f6
review changes + linter warning fixes in super modern skin
alesmaye Jul 23, 2024
c62b241
review changes
alesmaye Jul 24, 2024
0e85219
Merge pull request #635 from bitmovin/feature/settings-menu-style
alesmaye Jul 25, 2024
b795e85
the new "touchcontroloverlay" now works independently from the UICont…
alesmaye Jul 29, 2024
80436d4
seeking works now
alesmaye Jul 29, 2024
bec1acc
seek load fix
alesmaye Jul 31, 2024
0ab5580
double tab has to be in a specific range
alesmaye Jul 31, 2024
44769b6
linter fixes
alesmaye Jul 31, 2024
c20d688
Merge branch 'feature/tap-detector-overlay' into feature/modern-ui-base
alesmaye Jul 31, 2024
ff8f72e
Merge pull request #636 from bitmovin/feature/modern-ui-base
alesmaye Jul 31, 2024
dd0875d
Revert "Merge linter fixes into tap-detector-overlay"
alesmaye Jul 31, 2024
92f665d
Merge pull request #637 from bitmovin/revert-636-feature/modern-ui-base
alesmaye Jul 31, 2024
6ed906f
the new "touchcontroloverlay" now works independently from the UICont…
alesmaye Jul 29, 2024
aa1b2e7
seeking works now
alesmaye Jul 29, 2024
0ba0e51
seek load fix
alesmaye Jul 31, 2024
fc8ae7d
double tab has to be in a specific range
alesmaye Jul 31, 2024
c4838e2
linter fixes
alesmaye Jul 31, 2024
2dda4f3
Revert "Merge linter fixes into tap-detector-overlay"
alesmaye Jul 31, 2024
2d281f8
Merge branch 'feature/tap-detector-overlay' of https://github.com/bit…
alesmaye Jul 31, 2024
f019a16
the new "touchcontroloverlay" now works independently from the UICont…
alesmaye Jul 29, 2024
cea6bba
seeking works now
alesmaye Jul 29, 2024
d79fe04
linter fixes
alesmaye Jul 31, 2024
90e8787
Revert "Merge linter fixes into tap-detector-overlay"
alesmaye Jul 31, 2024
228ff82
test
alesmaye Jul 31, 2024
a51dc1a
comment
alesmaye Aug 1, 2024
bad49a5
Merge branch 'feature/modern-ui-base' into feature/tap-detector-overlay
alesmaye Aug 1, 2024
7654b62
linter and merge fixes
alesmaye Aug 1, 2024
d07e55f
LINTER
alesmaye Aug 1, 2024
eee1330
L I N T E R
alesmaye Aug 1, 2024
b607ff8
some refactoring
alesmaye Aug 1, 2024
fdb1a44
bug fix tap tap position
alesmaye Aug 1, 2024
3110710
linter AGAIN
alesmaye Aug 1, 2024
54a8b4a
created new menu components
alesmaye Aug 1, 2024
072be35
fixed some linter warinings
alesmaye Aug 1, 2024
2d46227
review changes
alesmaye Aug 1, 2024
398e0a4
LINTER
alesmaye Aug 1, 2024
56ec3ca
rafactored all components that have to do somethin with the settings …
alesmaye Aug 1, 2024
f80d09f
removed commended line
alesmaye Aug 2, 2024
8be63ad
Merge pull request #639 from bitmovin/feature/tap-detector-overlay
alesmaye Aug 2, 2024
75bfda6
settings menu working without subtites
alesmaye Aug 14, 2024
368b781
subtitle language select inside the new settings menu
alesmaye Aug 19, 2024
4754ab9
linter fixes
alesmaye Aug 19, 2024
5e799e2
Merge branch 'feature/modern-ui-base' into feature/complete-settings-…
alesmaye Aug 19, 2024
9baef8e
fixes
alesmaye Aug 19, 2024
18c61ec
Merge branch 'feature/complete-settings-menu' of https://github.com/b…
alesmaye Aug 19, 2024
7a9e290
settings hide
alesmaye Aug 19, 2024
059bbec
button interaction
alesmaye Aug 19, 2024
b6f5a0f
button style changes
alesmaye Aug 19, 2024
6b6d721
addet the amount of available subtitles next to the current selected …
alesmaye Aug 19, 2024
f85c0cc
made the linter happy
alesmaye Aug 19, 2024
488f350
subtitleToggleButton now opens the subtitle select menu, when no pres…
alesmaye Aug 19, 2024
6c09514
Merge pull request #644 from bitmovin/feature/button-interaction
alesmaye Aug 20, 2024
67697a8
seek animation works but without label with seeked seconds
alesmaye Aug 22, 2024
aa86650
seeking time label and linter fixes
alesmaye Aug 22, 2024
3726b9b
updated color
alesmaye Aug 22, 2024
ac72a2c
fixed import
alesmaye Aug 27, 2024
224bec7
updated icons
alesmaye Aug 27, 2024
e476be5
removed unnecessary icons
alesmaye Aug 27, 2024
76b71bf
layout changes
alesmaye Aug 28, 2024
0bd8852
new settings panel now extends old settings panel
alesmaye Aug 29, 2024
54582f4
linter
alesmaye Aug 29, 2024
1b46c83
Merge pull request #646 from bitmovin/feature/add-seek-animation
alesmaye Aug 29, 2024
1ae93f8
Merge branch 'feature/modern-ui-base' into feature/complete-settings-…
alesmaye Aug 29, 2024
8c2ed58
build the ui according to the design
alesmaye Aug 30, 2024
f375aac
loading animation
alesmaye Aug 30, 2024
c930f11
loading animation
alesmaye Aug 30, 2024
76cefbc
Merge branch 'feature/loading-animation' of https://github.com/bitmov…
alesmaye Aug 30, 2024
81c578c
css
alesmaye Sep 2, 2024
62c184b
loading icon working
alesmaye Sep 2, 2024
62c4147
code fix
alesmaye Sep 2, 2024
5b7fdb5
fix comment
bitmovin-kenny Sep 13, 2024
8b65326
Merge pull request #648 from bitmovin/feature/general-ui-styling
bitmovin-kenny Sep 13, 2024
5b6f6d8
Merge branch 'feature/modern-ui-base' into feature/loading-animation
bitmovin-kenny Sep 13, 2024
97b5cd6
Merge pull request #649 from bitmovin/feature/loading-animation
bitmovin-kenny Sep 13, 2024
0248c6a
Merge branch 'develop' into feature/modern-ui-base
bitmovin-kenny Sep 13, 2024
d1152b2
add explicit factory method for mobile ui
stonko1994 Oct 1, 2024
8bc0894
Merge pull request #643 from bitmovin/feature/complete-settings-menu
stonko1994 Oct 1, 2024
b555124
fix code formatting in uifactory
stonko1994 Nov 6, 2024
42ecf15
add the new look and feel for the web based UI variant
stonko1994 Dec 3, 2024
5320f5e
enable the modern settings panel in browsers
stonko1994 Dec 3, 2024
6579335
enable new seekbar rendering
stonko1994 Dec 3, 2024
9165ec2
improve various margins, paddings and sizes to improve UX
stonko1994 Dec 4, 2024
d3e4e54
revert buffer size bar back to white
stonko1994 Dec 4, 2024
3777d51
use new fullscreen icon
stonko1994 Dec 4, 2024
e14eb24
revert back to our current buffering overlay styling
stonko1994 Dec 4, 2024
58d2ab2
add an action to show the buffering overlay to the playground
stonko1994 Dec 4, 2024
2987add
remove leftover import
stonko1994 Dec 4, 2024
5ff17c4
refactor the modern settings panel to add support for subtitle settin…
stonko1994 Dec 6, 2024
ea9fc09
clear hide timeout on mouse move
stonko1994 Dec 6, 2024
0c0e9fd
add a min gap between elements in a settings panel item
stonko1994 Dec 6, 2024
545e680
remove dynamic pages from DOM after navigating back
stonko1994 Dec 6, 2024
64dad45
replace hardcoded back text with localization
stonko1994 Dec 9, 2024
6f21cbf
improve typing for optional settings
stonko1994 Dec 9, 2024
cf3ff8a
cleanup duplicate css for settings panel items
stonko1994 Dec 9, 2024
5530ae4
enable the subtitle settings for the new ui layout
stonko1994 Dec 9, 2024
691736d
add option to quickly switch to a portrait layout
stonko1994 Dec 9, 2024
47106e2
split ui select box to simplify selection
stonko1994 Dec 9, 2024
cafd7af
improve ui variant collection
stonko1994 Dec 9, 2024
17b797b
add action button to trigger the buffering overlay
stonko1994 Dec 9, 2024
910cc75
fix css linting
stonko1994 Dec 9, 2024
c7c53a3
Merge pull request #657 from bitmovin/feature/simplify-ui-switching
stonko1994 Dec 9, 2024
5e4dc8b
Merge branch 'feature/modern-ui-base' into feature/super-modern-ui-fo…
stonko1994 Dec 9, 2024
8b17739
remove commented out styles
stonko1994 Dec 9, 2024
895ef35
Merge branch 'feature/super-modern-ui-for-web' of github.com:bitmovin…
stonko1994 Dec 9, 2024
3461a30
Merge branch 'feature/super-modern-ui-for-web' into feature/super-mod…
stonko1994 Dec 9, 2024
d1ca093
add empty line at EOF
stonko1994 Dec 9, 2024
ebd13e4
remove the ModernSettingsPanel and ModernSettingsPanelPage and merge …
stonko1994 Dec 9, 2024
f2b581b
rename modern settings component to dynamic
stonko1994 Dec 9, 2024
9fb9cc0
improve settingspanelitem initialization and configuration
stonko1994 Dec 9, 2024
70b519a
fallback to the default UI if local storage contains invalid UI
stonko1994 Dec 10, 2024
0d9e490
improve subtitle example overlay access
stonko1994 Dec 10, 2024
9c6c20f
add documentation
stonko1994 Dec 10, 2024
9626fed
remove outdated todo
stonko1994 Dec 10, 2024
a0497f5
minor code style improvements
stonko1994 Dec 10, 2024
0dff63a
add support to include the SubtitleSettingsPanelPage in the old and n…
stonko1994 Dec 10, 2024
ad708ce
hide the eco mode container behind the ecoMode flag when creating the…
stonko1994 Dec 10, 2024
b2e0324
fix failing tests
stonko1994 Dec 10, 2024
b7df070
fix wrong mouse listener element in seekbar
stonko1994 Dec 10, 2024
5dbc958
revert seekbar changes to current develop state
stonko1994 Dec 10, 2024
0f1d5ec
minor code style improvements
stonko1994 Dec 10, 2024
888b22f
add wrong root level css selector
stonko1994 Dec 10, 2024
e5aada0
remove smaller font size for small screen variant
stonko1994 Dec 10, 2024
a2b58da
remove webkit tap highlight color
stonko1994 Dec 10, 2024
cbc7989
blur background for settings panel
stonko1994 Dec 10, 2024
d1a10bb
add shadow for settings panel
stonko1994 Dec 10, 2024
9a8e473
remove unneeded vendor prefixes
stonko1994 Dec 10, 2024
cdef5a4
change size of settings label to full width on small screens
stonko1994 Dec 10, 2024
38f83ec
add missing removing from dynamic settings panel pages
stonko1994 Dec 11, 2024
563add2
apply common naming scheme to touchcontroloverlay
stonko1994 Dec 11, 2024
86ff8c6
add line-height to the settings panel item to ensure all have the sam…
stonko1994 Dec 11, 2024
76c794e
Merge pull request #654 from bitmovin/feature/super-modern-ui-for-web
stonko1994 Dec 11, 2024
67735c4
Merge pull request #658 from bitmovin/feature/improve-seekbar-interac…
stonko1994 Dec 11, 2024
fbfcee9
Merge branch 'feature/modern-ui-base' of github.com:bitmovin/bitmovin…
stonko1994 Dec 11, 2024
66b3186
Merge branch 'feature/super-modern-subtitle-settings-panel' into feat…
stonko1994 Dec 11, 2024
fea5db4
disable tap highlight color in webkit browsers
stonko1994 Dec 11, 2024
b569fb9
add ad skip button image
stonko1994 Dec 18, 2024
0e51dbc
add adstatusoverlay component and styling
stonko1994 Dec 18, 2024
7a009c4
extract ad skip button styling into separate component
stonko1994 Dec 18, 2024
f56d889
add ad color
stonko1994 Dec 18, 2024
b232e1a
fix seekbar flickering before ads when player duration is 0
stonko1994 Dec 18, 2024
b76e145
export the AdStatusOverlay
stonko1994 Dec 18, 2024
cb7558b
add advertising UI variants for the new UI layout
stonko1994 Dec 18, 2024
05aa183
add new line at EOF
stonko1994 Dec 18, 2024
8a99ee5
fix linter issues
stonko1994 Dec 18, 2024
b7a0f42
add new line at EOF
stonko1994 Dec 18, 2024
93047fe
Merge branch 'feature/modern-ui-base' into feature/super-modern-subti…
stonko1994 Dec 19, 2024
59a7bf5
rename setting to settingComponent
stonko1994 Dec 20, 2024
ae1838a
Merge branch 'feature/super-modern-subtitle-settings-panel' of github…
stonko1994 Dec 20, 2024
901be17
fix test build after renaming
stonko1994 Dec 20, 2024
77d2044
Merge pull request #655 from bitmovin/feature/super-modern-subtitle-s…
stonko1994 Dec 20, 2024
74d33a9
Merge branch 'feature/modern-ui-base' into feature/improve-mobile-layout
stonko1994 Dec 20, 2024
cbd3f61
Merge pull request #659 from bitmovin/feature/improve-mobile-layout
stonko1994 Dec 20, 2024
291c093
Merge pull request #660 from bitmovin/feature/new-advertising-ui
stonko1994 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/ad-skip.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/airplay.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/angle-left.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/angle-right.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions assets/skin-super-modern/images/cast.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/check.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/close.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/dot-play.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/dot-volume.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions assets/skin-super-modern/images/fullscreen.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions assets/skin-super-modern/images/fullscreenX.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/glasses.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/leaf.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 18 additions & 0 deletions assets/skin-super-modern/images/loader.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions assets/skin-super-modern/images/more.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/music-low.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/music-mid.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/next.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/pause.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/pip.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/play.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/playlist.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/point.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions assets/skin-super-modern/images/prev.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions assets/skin-super-modern/images/quickseek-back.svg
View file
Open in desktop
5 changes: 5 additions & 0 deletions assets/skin-super-modern/images/quickseek-fastforward.svg
View file
Open in desktop
9 changes: 9 additions & 0 deletions assets/skin-super-modern/images/quickseek-forward.svg
View file
Open in desktop
5 changes: 5 additions & 0 deletions assets/skin-super-modern/images/quickseek-rewind.svg
View file
Open in desktop
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/reload.svg
View file
Open in desktop
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/setting.svg
View file
Open in desktop
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/share.svg
View file
Open in desktop
3 changes: 3 additions & 0 deletions assets/skin-super-modern/images/stop.svg
View file
Open in desktop
Loading
Loading