Enable the new UI design on browsers #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
changed the title
stonko1994
commented
Dec 9, 2024
| pageTransitionAnimation: true, | ||
| }); | ||
|
|
||
| // let subtitleSettingsPanelPage = new SubtitleSettingsPanelPage({ |
There was a problem hiding this comment.
Will be added in #655
…/bitmovin-player-ui into feature/super-modern-ui-for-web
|
At 100% render size i get a scroll bar when opening the settings, I guess this should not happen.
Otherwise LGTM |
It looks like there is a tiny bit of scrolling. The settings panel will be 'reworked' in #655 where I can't reproduce this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our new UI design is currently only enabled for small screen variants which is meant for mobile. We also want to have it on all platforms though. This PR enables the new design for browsers.
Changes:
Key parts which are still missing
Checklist (for PR submitter and reviewers)
CHANGELOGentry A final changelog entry for the new design will be added at the end