Improve demopage #629
Merged
Improve demopage #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in localStorage and reload on site load
felix-hoc
requested changes
Jun 28, 2024
| @@ -256,6 +262,8 @@ <h4 class="card-title"> | |||
| var uiManager; | |||
| bitmovin.playerui.UIManager.setLocalizationConfig({ language: 'en', browserLanguageDetection: false }); | |||
|
|
|||
| bitmovin.player.Player.addModule(bitmovin.player["advertising-bitmovin"].default); | |||
There was a problem hiding this comment.
Why the switch to the Bitmovin Ads module? The default is IMA, shouldn't the UI use the default player config?
There was a problem hiding this comment.
Because with IMA there is no control over the UI as IMA provides the minimal ads UI which cannot officially (and must not) be customized. With BAM this is possible to use our UI, so that made more sense to me.
|
Thanks @felix-hoc! Classic case of testing it, then refactoring the code and introduce a bug by that 😄 |
felix-hoc
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two small but hopefully useful improvements of the playground demo page:
Checklist (for PR submitter and reviewers)
CHANGELOGentry