Fix no subtitle on switching tracks #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did some manual testing and the changes looks okay. The only thing I can see is that we are getting 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When switching between different subtitle track, sometime it does not show the subtitle cue anymore.
We are clearing subtitle label component on
SubtitleEnabledandSubtitleDisabled. This should be added again onCueEnterevent.The event sequence coming from Player is sometime off. When enabling subtitle, the sequence of event looks like,
SubtitleEnable,CueEnterandSubtitleEnabled. This makes the Label component added and removed again, causing no subtitle being shown.We are now not removing the component on
SubtitleEnabledbut just onSubtitleDisabled. This should be enough as a previous subtitle is disabled when a new one is enabled.Checklist (for PR submitter and reviewers)
CHANGELOGentry