Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable localStorage access #613

Closed
wants to merge 12 commits into from

Conversation

Andr3wid
Copy link
Contributor

@Andr3wid Andr3wid commented Mar 26, 2024

Description

So far, there hasn't been a way to disable localStorage access for the bitmovin-player-ui. In this PR, following changes are introduced:

  • Adds a disableLocalStorageApi-flag
  • Respects that flag in the storageutils.ts (which are used to interact with the browser's localStorage API)

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

@Andr3wid Andr3wid self-assigned this Mar 26, 2024
@Andr3wid Andr3wid changed the base branch from develop to fix/PW-10974/localstorage-check March 26, 2024 12:09
Base automatically changed from fix/PW-10974/localstorage-check to develop March 26, 2024 12:24
@Andr3wid Andr3wid changed the base branch from develop to dependabot/npm_and_yarn/json5-2.2.3 March 26, 2024 12:30
@Andr3wid Andr3wid changed the base branch from dependabot/npm_and_yarn/json5-2.2.3 to develop March 26, 2024 12:30
@Andr3wid Andr3wid marked this pull request as ready for review March 26, 2024 12:32
@Andr3wid Andr3wid closed this Apr 25, 2024
@Andr3wid Andr3wid deleted the feature/disable-localstorage-config branch April 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant