Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Eco Mode Toggle #571

Merged
merged 85 commits into from
Jun 6, 2024

Conversation

mariacrdribeiro
Copy link
Contributor

@mariacrdribeiro mariacrdribeiro commented Aug 11, 2023

The Eco Mode enables users to support sustainability and decrease energy usage when streaming videos. This is achieved through a toggle button that establishes resolution limits based on the codec in use.

Added Features:

  • Eco Mode Toggle Button;
  • Configuration option to hide/show the Eco Mode.

Copy link
Contributor

@Andr3wid Andr3wid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits :) @Andr3wid

src/ts/components/ecomodecontainer.ts Show resolved Hide resolved
src/ts/components/ecomodecontainer.ts Outdated Show resolved Hide resolved
src/ts/components/ecomodecontainer.ts Outdated Show resolved Hide resolved
src/ts/components/ecomodecontainer.ts Outdated Show resolved Hide resolved
src/ts/components/ecomodecontainer.ts Show resolved Hide resolved
@Andr3wid Andr3wid self-assigned this Jun 5, 2024
@Andr3wid Andr3wid requested a review from jmsn June 6, 2024 10:08
@Andr3wid Andr3wid marked this pull request as ready for review June 6, 2024 11:01
src/ts/localization/languages/en.json Show resolved Hide resolved
src/ts/components/ecomodetogglebutton.ts Outdated Show resolved Hide resolved
src/ts/components/ecomodetogglebutton.ts Outdated Show resolved Hide resolved
src/ts/components/ecomodecontainer.ts Outdated Show resolved Hide resolved
src/ts/uifactory.ts Outdated Show resolved Hide resolved
src/ts/uifactory.ts Outdated Show resolved Hide resolved
Comment on lines 93 to 94
}
mainSettingsPanelPage = new SettingsPanelPage({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last NIT: Can you please add a line break here? 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 🙂
Add newline

@Andr3wid Andr3wid merged commit 42a7a96 into develop Jun 6, 2024
2 checks passed
@Andr3wid Andr3wid deleted the feature/PW-10573/implementing-eco-mode-toggle branch June 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants