Refactor code to use Uint8Array instead of Buffer #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of the code to use
Uint8Array
s instead ofBuffer
, which would basically make this library usable in the browser without any polyfill for Node.js internals.I've had an issue with extending typeforce (due to no support for
Uint8Array
), which is IMO outdated library which doesn't have ES6 support, doesn't even translate type safety to Typescript and is very hard to extend properly. I would be in favor of getting rid of it and using custom type guards instead but didn't want to inlude such change yet in this PR.I am aware of the fact that this change might warrant releasing a major version of the library but that is unavoidable in this case.
Let me know what you think and we can discuss