Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uniffi-rs version to 0.28.0 and MSRV to 1.77.1 #624

Merged

Conversation

notmandatory
Copy link
Member

Description

Bump uniffi-rs version to 0.28.0 and MSRV to 1.77.1 to support new uniffi-rs features and prepare users to upgrade to bdk 1.0.0 bdk-ffi version.

Notes to the reviewers

This PR replaces #622.

Changelog notice

  • Bump uniffi-rs to 0.28.0 to support new uniffi-rs features.
  • Bump MSRV to 1.77.1 to align with bdk-ffi 1.0.0-beta.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

jurvis and others added 2 commits November 5, 2024 14:28
This commit aligns the MSRV with current bdk-ffi 1.0.0-beta MSRV.
@notmandatory notmandatory self-assigned this Nov 6, 2024
@notmandatory notmandatory added dependency: uniffi-rs CI Continuous integration pipeline related labels Nov 6, 2024
Bumping package version since MSRV and uniffi version bumps are breaking changes.
@notmandatory notmandatory force-pushed the bump_uniffi_0280 branch 23 times, most recently from 80bfae3 to b14a8af Compare November 7, 2024 22:14
@notmandatory
Copy link
Member Author

Tests passing, ready for review.

@notmandatory notmandatory mentioned this pull request Nov 8, 2024
3 tasks
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 93bf63b.

@thunderbiscuit thunderbiscuit merged commit 93bf63b into bitcoindevkit:release/0.31 Nov 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration pipeline related dependency: uniffi-rs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants