Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1337): new transaction flow - type 42; paymail; operations #837

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Jan 3, 2025

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 49.04306% with 426 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (e776a4b) to head (b1cdfa5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/paymail/paymail_service_provider.go 0.00% 133 Missing ⚠️
engine/transaction/record/tx_flow.go 64.76% 26 Missing and 11 partials ⚠️
actions/users/operations.go 0.00% 28 Missing ⚠️
engine/database/dao/transactions.go 62.90% 15 Missing and 8 partials ⚠️
engine/utils/collect_ancestors.go 0.00% 23 Missing ⚠️
engine/database/paginate.go 69.09% 11 Missing and 6 partials ⚠️
engine/transaction/record/record_transaction.go 54.28% 11 Missing and 5 partials ⚠️
actions/users/balance.go 0.00% 14 Missing ⚠️
engine/database/tracked_transaction.go 57.57% 10 Missing and 4 partials ⚠️
engine/tester/fixtures/tx_fixtures.go 17.64% 14 Missing ⚠️
... and 17 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   46.19%   46.28%   +0.08%     
==========================================
  Files         371      379       +8     
  Lines       17881    18481     +600     
==========================================
+ Hits         8261     8554     +293     
- Misses       8999     9247     +248     
- Partials      621      680      +59     
Flag Coverage Δ
unittests 46.28% <49.04%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/paymailserver/register.go 100.00% <100.00%> (ø)
...ons/testabilities/fixture_spvwallet_application.go 88.88% <ø> (ø)
actions/users/routes.go 100.00% <100.00%> (ø)
engine/database/models.go 100.00% <100.00%> (ø)
engine/database/testabilities/fixture_database.go 100.00% <100.00%> (ø)
engine/database/testabilities/user_utxo_fixture.go 100.00% <100.00%> (ø)
engine/keys/type42/pki.go 100.00% <100.00%> (ø)
engine/testabilities/fixture_configopts.go 100.00% <100.00%> (ø)
engine/testabilities/fixture_engine.go 90.00% <100.00%> (-0.27%) ⬇️
.../outlines/internal/inputs/inputs_query_composer.go 100.00% <100.00%> (ø)
... and 30 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3b616...b1cdfa5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants