Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-1220): rename variables to not shadow internal go funcs #298

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(SPV-1220): rename variables to not shadow internal go funcs #298

merged 1 commit into from
Nov 25, 2024

Conversation

wregulski
Copy link
Contributor

@wregulski wregulski commented Nov 25, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski self-assigned this Nov 25, 2024
@wregulski wregulski requested a review from a team as a code owner November 25, 2024 15:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @jakubmkowalski resulted in success.

@wregulski wregulski added the regression-tests Runs regression tests label Nov 25, 2024
@jakubmkowalski jakubmkowalski added the tested PR was tested by a team member label Nov 25, 2024
@wregulski wregulski added regression-tests Runs regression tests and removed regression-tests Runs regression tests labels Nov 25, 2024
@wregulski wregulski merged commit 6ab8526 into main Nov 25, 2024
18 of 20 checks passed
@wregulski wregulski deleted the chore/spv-1220 branch November 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubmkowalski jakubmkowalski jakubmkowalski approved these changes

Assignees

@wregulski wregulski

Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wregulski @jakubmkowalski