Bio::Tools::CodonTable: enable selection of table id=0 on constructor (…

…#386)
bioperl · Apr 26, 2024 · 62ee9df · 62ee9df
1 parent cfc66e5
commit 62ee9df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/Bio/Tools/CodonTable.pm b/lib/Bio/Tools/CodonTable.pm
@@ -255,7 +255,7 @@ sub new {
              @args);
 
     $id = 1 if ( ! defined ( $id ) );
-    $id  && $self->id($id);
+    $self->id($id);
     return $self; # success - we hope!
 }
 

diff --git a/t/SeqTools/CodonTable.t b/t/SeqTools/CodonTable.t
@@ -6,7 +6,7 @@ use strict;
 BEGIN {
     use Bio::Root::Test;
 
-    test_begin(-tests => 86);
+    test_begin(-tests => 87);
 
     use_ok('Bio::Tools::CodonTable');
     use_ok('Bio::CodonUsage::IO');
@@ -18,6 +18,10 @@ my $myCodonTable = Bio::Tools::CodonTable -> new ( -id => 16);
 ok defined $myCodonTable;
 isa_ok $myCodonTable, 'Bio::Tools::CodonTable';
 
+# Access to ID table 0 through constructor
+$myCodonTable = Bio::Tools::CodonTable->new( -id => 0);
+is $myCodonTable->id(), 0;
+
 # defaults to ID 1 "Standard"
 $myCodonTable = Bio::Tools::CodonTable->new();
 is $myCodonTable->id(), 1;