fix header emitted from gpad writer to match 2.0 specifications #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assoc writer files
|
@dustine32 - can you take a look at the changes I made to validate.py here? Not ready to merge yet, just wanted a second pair of eyes on the changes I made to carry forward the model details from noctua GPADs through to the final GPADs produced by the pipeline. :) |
dustine32
approved these changes
Feb 6, 2024
bin/validate.py
Outdated
| )) | ||
|
|
||
| click.echo("Making noctua gpad products...") | ||
| with click.progressbar(iterable=gpadparser.association_generator(file=nf), length=lines) as associations: |
There was a problem hiding this comment.
The only nit-picky thing that you wouldn't really need to change (or I'm reading it wrong) is this lines might be the count of lines in gaf_path above (line 347) and not noctua_gpad_file as I think is intended.
|
Tag back to geneontology/pipeline#325 |
|
#675 should be merged to main, then integrated here (basically a replacement of this PR with that one). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I did not update the header in the tests that specifically request GPAD 1.2. This PR should not be merged yet.