null check with_from items #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mugitty is going to push an update to this |
|
After discussing with @dustine32, we decided to make additional changes. I have committed additional changes |
mugitty
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Failure of gorule16 is soft. Need to ensure assoc.evidence.with_support_from is not None before traversing
mugitty
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Gorule16 needs to verify that for annotation with code ECO, at least one of the with/from is a go term that is not same as the go term for the annotation
mugitty
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Added test case for Gorule16 where GPAD parser creates annotation with evidence code ECO that does not have a with/from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.