Fixes v. 0.0.10 bugs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasade
reviewed
Jun 12, 2024
gemelli/rpca.py
Outdated
| table = table.filter(frequency_filter, axis='observation') | ||
| table = table.filter(sample_filter, axis='sample') | ||
| if min_feature_count is not None: | ||
| table = table.filter(observation_filter, axis='observation') |
There was a problem hiding this comment.
Note these operations are inplace by default. If that is not expected, suggest either creating a copy prior, or passing inplace=False
There was a problem hiding this comment.
Good to know. I added inplace=False just for continuities sake. Thanks!
gemelli/rpca.py
Outdated
| if min_feature_frequency is not None: | ||
| table = table.filter(frequency_filter, axis='observation') | ||
| if min_sample_count is not None: | ||
| table = table.filter(sample_filter, axis='sample') |
There was a problem hiding this comment.
Suggest ensuring empty samples / features are removed just in case
Suggested change
| table = table.filter(sample_filter, axis='sample') | |
| table = table.filter(sample_filter, axis='sample') | |
| table = table.remove_empty() |
There was a problem hiding this comment.
Added! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
The filtering is ignored if the transformation/filtering is done before running tempted.
The HTML files are not packaged with the release in the setup.py.
--p-no-svd-centralizednot working? #82If no-centering is done then the original table list is used.