Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openms 2.8 #33351

Merged
merged 38 commits into from
Feb 27, 2022
Merged

Openms 2.8 #33351

merged 38 commits into from
Feb 27, 2022

Conversation

jpfeuffer
Copy link
Contributor

Updates OpenMS to 2.8 and splits pyopenms from it again (since we finally are exporting OpenMS via CMake correctly).


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@bgruening
Copy link
Member

So many people waiting for this release :) ping @bernt-matthias :)

@bernt-matthias
Copy link
Contributor

I'm already one release back wrt the galaxy wrappers. Will work on this the next weeks.

@jpfeuffer
Copy link
Contributor Author

@bernt-matthias what was the additional thirdparty you wanted to add?

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Feb 23, 2022

this PR depends on this: bioconda/bioconda-utils#751
(not anymore. I removed pyopenms from here and will submit a PR after this one is merged)

@jpfeuffer
Copy link
Contributor Author

and fixing of conflicts in thirdparty

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Feb 25, 2022

Ok, it seems like you are not allowed to specify (valid and matching) version ranges of pinned packages since conda is bugged.

@jpfeuffer
Copy link
Contributor Author

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot
Copy link
Collaborator

I received an error uploading the build artifacts or merging the PR!

@jpfeuffer
Copy link
Contributor Author

@BiocondaBot Which error did you receive?

@jpfeuffer
Copy link
Contributor Author

@bioconda/core should be ready to merge. pyOpenMS comes separately now, as mentioned.

@BiocondaBot
Copy link
Collaborator

Reposting for @jpfeuffer to enable pings (courtesy of the BiocondaBot):

@bioconda/core should be ready to merge. pyOpenMS comes separately now, as mentioned.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup!

@bgruening bgruening merged commit 1dc5aeb into bioconda:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants