Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Prefix permission system #290

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Refactor the Prefix permission system #290

merged 3 commits into from
Apr 1, 2024

Conversation

HadleyKing
Copy link
Collaborator

  • Prefix required it's own two groups and the creation of 5 permissions for each prefix. Look up for authentication was time consuming and taxing on DB. Users also had no idea how to use the system, just what to do to make it work.
  • Propose to remove groups altogether from the prefix model. if it is empty then anyone can use it. If populated than only with the permission can use it

@HadleyKing
Add prefix creation function
bce794b 
Changes to be committed:
	modified:   authentication/services.py
	modified:   biocompute/models.py
	modified:   config/settings.py
	modified:   docs/refactor.md
	modified:   prefix/apis.py
	modified:   prefix/models.py
	modified:   prefix/services.py
	modified:   tests/test_views/test_api_objects_drafts_create.py
@HadleyKing HadleyKing marked this pull request as draft March 26, 2024 21:48
@HadleyKing
Add Prefix Modify API endpoint
bacb265 
On branch prefix_perms
Your branch is up to date with 'origin/prefix_perms'.

Changes to be committed:
	modified:   config/services.py
	modified:   prefix/apis.py
	modified:   prefix/models.py
	modified:   prefix/selectors.py
	modified:   prefix/services.py
@HadleyKing
response_c
87c4aea
@HadleyKing HadleyKing marked this pull request as ready for review April 1, 2024 17:00
@HadleyKing HadleyKing merged commit f308a9c into model_refactor Apr 1, 2024
1 of 2 checks passed
@HadleyKing HadleyKing deleted the prefix_perms branch April 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HadleyKing