This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
Mayuran/DPROD-3691/accumulator video #7444
Merged
aswathy-deriv
merged 15 commits into
binary-com:master
from
mayuran-deriv:mayuran/accumulator_video
Apr 18, 2024
Merged
Mayuran/DPROD-3691/accumulator video #7444
aswathy-deriv
merged 15 commits into
binary-com:master
from
mayuran-deriv:mayuran/accumulator_video
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayuran-deriv
requested review from
habib-deriv,
prince-deriv,
mitra-deriv and
fasihali-deriv
as code owners
March 28, 2024 07:58
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mayuran-deriv
changed the title
Mayuran/accumulator video
Mayuran/DPROD-3691/accumulator video
Mar 31, 2024
hasan-deriv
suggested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split the page component as we discussed. It is unreadable now.
themes/gatsby-theme-deriv/src/features/pages/options/accumulator/index.tsx
Outdated
Show resolved
Hide resolved
themes/gatsby-theme-deriv/src/features/components/quill/videoModal/index.tsx
Outdated
Show resolved
Hide resolved
mayuran-deriv
force-pushed
the
mayuran/accumulator_video
branch
from
April 2, 2024 14:56
02fed99
to
d83df5b
Compare
…/accumulator_video
habib-deriv
previously approved these changes
Apr 3, 2024
hasan-deriv
approved these changes
Apr 3, 2024
…/accumulator_video
|
|
Quality Gate passedIssues Measures |
Preview Link: https://row-mayuran-accumulator1.deriv-com-preview-links.pages.dev
|
Preview Link: https://eu-mayuran-accumulator1.deriv-com-preview-links.pages.dev
|
🚀 Smoke test run EU (2) passed successfully! |
🚀 Smoke test run EU (5) passed successfully! |
aswathy-deriv
approved these changes
Apr 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accumulator page improvements
Type of change