This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
DPROD-3065/Translation-new-homepage-performance #6867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: added quill-desgin and blocks to homepage * chore: updated deriv-com libs * chore: added more section and block usage * chore: updated images format and imports * Update tsconfig.json * chore: added base navigation for row * chore: added base home hero --------- Co-authored-by: Mohsen Hajibeigloo <[email protected]> Co-authored-by: Habib Deriv <[email protected]>
* Fix gtm partytown integration (#6038) * chore: fix gtm partytown integration * chore: remove defer Downloading the script asynchronously is enough * chore: default theme to light --------- Co-authored-by: Habib Deriv <[email protected]>
* chore: home v2 hero image * chore: overflow hidden * empty: 🚀 to redeploy and trigger build * chore: added @parcel/watcher --------- Co-authored-by: Michio <[email protected]>
* chore: updated stats component * chore: added chore value --------- Co-authored-by: Fasih Ali <[email protected]>
Co-authored-by: Fasih Ali <[email protected]>
* feat: update footer cta * chore: update footer cta * chore: update latest * chore: update footer cta
* chore: update latest navigation fixed the footer responsive issue updated the illustrations * chore: update navigation links in header navigation, footer updated quill-design, quill-icons, deriv-com-libs
* chore: added live market blocks * chore: fixed description * chore: updated package
Co-authored-by: meenu-deriv <[email protected]>
* chore: platform section * chore: remove fragment --------- Co-authored-by: Michio <[email protected]>
* feat: update footer cta * chore: update latest * fix: cta button only show on desktop size * chore: uncomment * chore: remove unwanted image * chore: solve livemarket issue * chore: clean code * fix: hide button for mobile and tablet * chore: fix package-lock
…com/deriv-com into translation-new-homepage
mitra-deriv
requested review from
habib-deriv,
yashim-deriv,
prince-deriv and
fasihali-deriv
as code owners
February 1, 2024 10:42
* fix: 🐛 fix arabic scroll issue in slider * fix: 🐛 fix change of the icon name coming from quill icons * fix: 🐛 fix rtl issue
* fix: 🔍 fix alt for svg * fix: 📦 update packages * empty: 🚀 to redeploy and trigger build * fix: 🐛 fix name of the icons
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 12 New issues |
Preview Link: https://translation-new-home.deriv-com-preview-links.pages.dev
|
🚀 Smoke test run (1) passed successfully! |
🚀 Smoke test run (3) passed successfully! |
🚀 Smoke test run (2) passed successfully! |
habib-deriv
added a commit
that referenced
this pull request
Feb 2, 2024
This reverts commit b8ad900.
habib-deriv
added a commit
that referenced
this pull request
Feb 2, 2024
habib-deriv
added a commit
that referenced
this pull request
Feb 2, 2024
This reverts commit b8ad900.
amir-deriv
pushed a commit
to amir-deriv/deriv-com
that referenced
this pull request
Feb 5, 2024
* chore: added quick translations * chore: update ts to tsx * chore: test trigger * chore: revert test * chore: added strings from data * chore: updated strings * Michio/setup migration branch beta (binary-com#6039) * chore: added quill-desgin and blocks to homepage * chore: updated deriv-com libs * chore: added more section and block usage * chore: updated images format and imports * Update tsconfig.json * chore: added base navigation for row * chore: added base home hero --------- Co-authored-by: Mohsen Hajibeigloo <[email protected]> Co-authored-by: Habib Deriv <[email protected]> * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Prince/update homepage theme (binary-com#6058) * Fix gtm partytown integration (binary-com#6038) * chore: fix gtm partytown integration * chore: remove defer Downloading the script asynchronously is enough * chore: default theme to light --------- Co-authored-by: Habib Deriv <[email protected]> * chore: home v2 hero (binary-com#6059) * chore: home v2 hero image * chore: overflow hidden * empty: 🚀 to redeploy and trigger build * chore: added @parcel/watcher --------- Co-authored-by: Michio <[email protected]> * Fasih: updated stats component (binary-com#6060) * chore: updated stats component * chore: added chore value --------- Co-authored-by: Fasih Ali <[email protected]> * chore: removed tailwind merge package (binary-com#6062) Co-authored-by: Fasih Ali <[email protected]> * Jia/add footer cta block (binary-com#6061) * feat: update footer cta * chore: update footer cta * chore: update latest * chore: update footer cta * Jia/footer cta fix (binary-com#6063) * feat: added the start trading steps (binary-com#6069) * nuzhy/update navigation and footer, illustrations (binary-com#6078) * chore: update latest navigation fixed the footer responsive issue updated the illustrations * chore: update navigation links in header navigation, footer updated quill-design, quill-icons, deriv-com-libs * Hasan/Translation 375 live pricing block (binary-com#6092) * chore: added live market blocks * chore: fixed description * chore: updated package * chore: implemented tabs for user friendly section (binary-com#6095) Co-authored-by: meenu-deriv <[email protected]> * chore: integrate language switcher (binary-com#6109) * chore: platform section (binary-com#6108) * chore: platform section * chore: remove fragment --------- Co-authored-by: Michio <[email protected]> * Jia/fix button desktop only (binary-com#6093) * feat: update footer cta * chore: update latest * fix: cta button only show on desktop size * chore: uncomment * chore: remove unwanted image * chore: solve livemarket issue * chore: clean code * fix: hide button for mobile and tablet * chore: fix package-lock * fix: footer download images, paddings (binary-com#6114) * chore: fixed tab blocks (binary-com#6116) * chore: language switch based on selection (binary-com#6120) * Jia/trade type options (binary-com#6119) * feat: update footer cta * chore: update latest * fix: trade type option background colour and icon size * chore: remove img * Jia/fasih: / fast payment section DPROD-378 (binary-com#6088) * feat: update footer cta * chore: update latest * feat: fast payment section * chore: nothing * chore: added data for infinte carousel * fix: removed unused code * fix: removed bg image --------- Co-authored-by: jia-deriv <[email protected]> Co-authored-by: Fasih Ali <[email protected]> * Jia/remove darkmode toggle (binary-com#6122) * feat: update footer cta * chore: update latest * chore: remove theme toggle * chore: cleanup code * nuzhy/added language direction change (binary-com#6123) * chore: added language direction change * fix: added comment to remove preview domain in future * fix: added localize text for translation (binary-com#6127) Co-authored-by: Michio <[email protected]> * Prince/added trustpilot section (binary-com#6137) * chore: truspilot rendering * chore: update package versions * chore: added translation for trustpilot texts * chore: temp static data * Nuzhy/footer fixes (binary-com#6142) * chore: update deriv-com-libs fix: deriv-go banner font issues * fix: start trading card title font sizes * Fasih/Update eu content (binary-com#6139) * chore: added EU data also need to fix some issues * fix: fixed package-lock file * fix: fixed object position for cta section --------- Co-authored-by: Fasih Ali <[email protected]> * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * chore: removed lmdb * chore: updated cards data (binary-com#6168) * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: updated the navigation, footer texts for translation (binary-com#6178) * Hasan/Translation 00 fix market and platforms (binary-com#6180) * chore: updated live market bottom data * chore: udpated packages and platform data * chore: fixed designers suggestions for hero content (binary-com#6174) * chore: fixed designers suggestions for hero content * chore: fixed hero height for tablet and desktop * chore: fixed hero height for tablet and desktop * chore: fixed hero image height * chore: fixed hero image height for mobile * chore: updated header button text * chore: updated years data * chore: updated years data * chore: updated gap between hero content and award image * chore: updated gap between hero content and award image * chore: updated award images alt text * chore: inprogress of adding link (binary-com#6159) * chore: inprogress of adding link * chore: fixed link component issue * chore: added keys for new tab redirection * chore: updated key * chore: updated nav data for UE * chore: updated footer and header nav * chore: added target blank condition * chore: chore updated target blank in data --------- Co-authored-by: Fasih Ali <[email protected]> * fix: text for trustpilot (binary-com#6181) * chore: added live pricing logic (binary-com#6183) * chore: updated all localize component (binary-com#6187) * chore: cta setup (binary-com#6188) * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Hasan/Translation 00 hero fix 3 (binary-com#6192) * chore: added format and loading in all hero images * chore: removed hero bg eu image * chore: updated hero subject image eu * chore: fixed company background (binary-com#6196) * chore: fixed item position (binary-com#6194) Co-authored-by: Fasih Ali <[email protected]> * fix: navigation subtasks (binary-com#6198) * fix: remove the testlink added for temporary (binary-com#6211) * fix: description changes (binary-com#6210) * Fasih/: added updated changes of blocks (binary-com#6225) * chore: added updated pull * chore: added speed --------- Co-authored-by: Fasih Ali <[email protected]> * Fasih/: added 3x images (binary-com#6219) * fix: added 3x images * chore: added lazy loading insted to eager --------- Co-authored-by: Fasih Ali <[email protected]> * Prince/DPROD-379/Fetch TrustPilot on build time (binary-com#6193) * chore: initial poc * chore: updated key structure * chore: trustpilot on commit fetch * chore: updated packages and generated data to json instead * chore: fetch trustpilot data on build * chore: reset data to test if fetching is working * chore: removed fixed todos * chore: fix comment * chore: simplified on build fetching * chore: add api keys on workflow * chore: removed unnecessary ignored files * chore: remove unnecessary change * chore: remove unnecessary change * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: default trustpilot values * fix: issue on rendering trustpilot data (binary-com#6246) * Hasan/Translation 2017 quill platform fix (binary-com#6247) * chore: fix eu platfrom card contnet * chore: updated quill-design pacakge * Fasih/fix infinite carousel speed (binary-com#6242) * chore: added updated pull * chore: added speed * chore: udpated data * chore: updated time duration --------- Co-authored-by: Fasih Ali <[email protected]> * chore: follow gatsby convention * Hasan/chore: fixed link component for eu (binary-com#6261) * chore: fixed link component for eu * chore: remove target from social links * chore: added show eu modal condition * chore: show modal condition for href * chore: show modal condition for href * chore: removed unused type * chore: updated deriv-com pacakges * chore: updated alert button onclick * Hasan/chore: fixed live market issues (binary-com#6244) * chore: sliced live market data * chore: fixed slider issues * chore: fixed edge slider issues * chore: added click handler for live market card * chore: updated live market buy sell click handler * chore: updated live market buy sell click handler * chore: updated live market buy sell click handler * chore: updated live market bottom content * chore: updated live market hook for stock and indices * chore: updated deriv-com pacakges * Hasan/Pr 00 quill remove floating cta (binary-com#6279) * chore: removed floating cta * empty: 🚀 to redeploy and trigger build * chore: removed floating cta * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: retrigger build * Hasan/Pr 375 live market issues 2 (binary-com#6288) * chore: fixed live market bottom link * chore: fixed live market bottom link * chore: updated market icons * chore: updated tab trigger content * chore: fixed card status * chore: added commoditiees icon * chore: removed parcel * chore: updated parcel * Hasan/chore: added media query based on height for hero award images (binary-com#6287) * chore: added media query based on height for hero award images * chore: added new parcel lib as optional * chore: updated media query height * auto-pull-translation * Prince/New homepage master update (binary-com#6356) * chore: merge master to new-homepage-translation * chore: quill-icon stable version usage * auto-pull-translation * fix: package-lock file * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Nuzhy/_/quill icons issue (binary-com#6386) * fix: quill-icons issue * fix: revert trustpilot review score * fix: update LabelPairedGridLgBoldIcon * Nuzhy/QUILL-1290/Update Home page (binary-com#6392) * fix: remove navigation, footer, providers which are integrated in layout * fix: deleted footer, navigation files from home page * Prince/Trustpilot debug (binary-com#6383) * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Aswathy/Steps homepage gap (binary-com#6382) * Hasan/Pr 00 add prefix to atomic css (binary-com#6334) * chore: added prefix to tryphography class Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to radius classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to spacing classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to color classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to flex classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to container classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to table classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to alert classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to tabs classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to accordion classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to icon classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to input classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to checkbox classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to visibility classes Signed-off-by: hasan-deriv <[email protected]> * chore: added prefix to utility classes Signed-off-by: hasan-deriv <[email protected]> * chore: updated utils functions Signed-off-by: hasan-deriv <[email protected]> * chore: updated quill icons package Signed-off-by: hasan-deriv <[email protected]> * chore: updated classname types Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in accordion component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in alert component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in card component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in container component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in flex component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in icon component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in input and checkbox component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in link component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in tab component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in table component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in typography component Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in molecules components Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in organisms components Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in templates components Signed-off-by: hasan-deriv <[email protected]> * chore: updated class names in pages components Signed-off-by: hasan-deriv <[email protected]> --------- Signed-off-by: hasan-deriv <[email protected]> * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Hasan/Pr 2169 quill layout (binary-com#6346) * chore: updated eslint rule * chore: updated gatsby browser * chore: added anchor component * chore: added broser alert component * chore: added layout overlay components * chore: added quill layout component * chore: removed css from layout component * chore: added quill layout to homepage * chore: removed css from page component * chore: added block and component css to global css * chore: removed ibm and ubuntu fonts * chore: updated tailwind config * auto-pull-translation * chore: removed block and component css from gatsby browser * chore: removed block and component css from layout * chore: updated quill layout * chore: updated banner font size * empty: 🚀 to redeploy and trigger build * chore: updated blocks (binary-com#6289) * chore: updated blocks * chore: updated with libs * fix: font size in eu changed * fix: added the space issue --------- Co-authored-by: fasihali-deriv <[email protected]> Co-authored-by: aswathy-deriv <[email protected]> * chore: request translation (binary-com#6455) * chore: request translation * fix: space * fix: unwanted words * Hasan/DPROD-2094/cfd banner fix (binary-com#6457) * auto-pull-translation * chore: updated cfd banner css * chore: updated font size breakpoint to xl * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Aswathy/Fast hassle issues (binary-com#6384) * fix: updated the package * fix: added the description for row * fix: payment block issues * Meenu/1334/Translation 1334 meenu 3 simple steps sub task (binary-com#6450) * fix: 3 steps subtask fix * empty: 🚀 to redeploy and trigger build * empty: 🚀 to redeploy and trigger build * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Hasan/DPROD-2159/live market card tarnslation fix (binary-com#6473) * auto-pull-translation * chore: added live market localize content * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * {DPRO-378}/ Translation 378 fix fast hassle block subtask (binary-com#6494) * fix: fix subtask * fix: fix changes * chore: updated icon package * chore: pr build failure fix * chore: pr build failure fix * Meenu/{DPROD-2331}/Translation 2331 fixx cta button 3 steps (binary-com#6496) * fix: fix subtask * fix: removed wrong commit * fix: fix changes * fix: fixed icon * fix: fixed conflicts * fix: updated with upstream * Pr 2169 quill layout fixes (binary-com#6462) * auto-pull-translation * chore: fixed ubuntu fonts * chore: fixed floating button bg color * chore: updated gatsby browser * chore: updated gatsby browser and global css file * chore: updated global css * chore: updated overlay css * chore: updated tailwind config * chore: cleanup * chore: updated global css and gatsby-browser * auto-pull-translation * chore: moved block css to gatsby browser from global css * Meenu/{DPROD-2331}/Pr 2331 gap issue for 3 steps (binary-com#6515) * fix: fixed padding issue * fix: fixed gap issue * Hasan/Pr 00 quill floating cta (binary-com#6406) * chore: added floating cta * chore: added logged in condition * chore: updated floating cta root margin * auto-pull-translation * chore: fixed the EU issue * chore: cleanup * chore: updated z index of floating cta * chore: moved unexpanded text to different component to get the correct ref * chore: removed unwanted file * chore: removed console * chore: updated layout overlay z index * chore: updated cta bottom height * chore: updated floating cta hook * auto-pull-translation * chore: removed floating cta hook and moved all the implementation to provider * chore: updated the breakpoint * chore: updated floating cta component * chore: updated different ref conditon for mobile and tablet * chore: updated floating cta blur and bg * chore: moved all cfd banner mobile text and desktop text in different component * chore: added expanded state to ctabottom useeffect * chore: synched floating button with cta * chore: updated floating button mb * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * empty: 🚀 to redeploy and trigger build * chore: added 2 more commands to update other external libs (binary-com#6467) * chore: added 2 more commands to update other external libs * translation: 📚 sync translations from crowdin feature branch --------- Co-authored-by: DerivFE <[email protected]> * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * empty: 🚀 to redeploy and trigger build * Pr 00 overlay fixes (binary-com#6585) * auto-pull-translation * chore: moved all the responsive css to css module * auto-pull-translation * Hasan/2170/eutestlink hero (binary-com#6472) * chore: added region loading condiition * chore: added region loading condition to text * chore: added region loading condition to image * chore: removed console * chore: added is eu domain condition to hero content * auto-pull-translation * chore: updated is_eu condition * chore: updated is_eu condition * chore: hero eu testing * auto-pull-translation * chore: added browser logic to hero imagge * chore: added browser logic to hero imagge * auto-pull-translation * chore: added browser logic to hero image * chore: added browser logic to hero image * chore: added browser logic to hero image * chore: cleanup * chore: cleanup * chore: fetching total trustpilot reviews (binary-com#6657) * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * hasan/Pr 00 rtl issue fix (binary-com#6451) * auto-pull-translation * chore: updated cta block * auto-pull-translation * chore: fixed ubuntu fonts * chore: fixed floating button bg color * chore: updated gatsby browser * chore: updated gatsby browser and global css file * chore: updated global css * chore: updated overlay css * chore: updated tailwind config * chore: cleanup * chore: updated global css and gatsby-browser * chore: added rtl classes for hero content and award images * chore: removed rtl dir from hero section * auto-pull-translation * chore: moved block css to gatsby browser from global css * chore: updated deriv packages * chore: updated deriv packages * auto-pull-translation * chore: live market description link fix * chore: updated deriv packages * auto-pull-translation * empty: 🚀 to redeploy and trigger build * chore: updated deriv packages * chore: updated fast payment animation * chore: updated fast payment animation * auto-pull-translation * chore: removed unused classname * auto-pull-translation * auto-pull-translation * chore: added rtl class to hero * Hasan/Pr 375 live market fix (binary-com#6436) * auto-pull-translation * chore: updated live market icons * chore: updated stock and indices array * chore: updated indices type * chore: added rest market icons * chore: updated forex description for EU * chore: updated deriv packages * chore: added mid value to live market data * auto-pull-translation * chore: updated market icon * chore: updated deriv packages * auto-pull-translation * chore: updated deriv packages * chore: updated deriv packages * chore: updated market icon * auto-pull-translation * chore: moved instrument truncate css to styles css * auto-pull-translation * chore: updated market icon * chore: updated deriv packages * chore: updated 20 years slider class * chore: updated live market hook * chore: updated live market hook * Hasan/Pr 00 live market icon (binary-com#6706) * auto-pull-translation * chore: added derived indices eu icons * fix: ⏪ add missing classname (binary-com#6717) * Pr 00 swiper issue (binary-com#6712) * auto-pull-translation * chore: added mr to swiper slide * Hasan/Pr 00 cta fix (binary-com#6742) * auto-pull-translation * chore: fixed floating cta issue * chore: removed comment * chore: removed console * chore: updated condiition * Mitra/DPROD-2166/Improve seo and accessibility (binary-com#6738) * fix: 🔍 improve seo and accessibility * Revert "Remove whatsapp icon" (binary-com#6739) * empty: 🚀 to redeploy and trigger build * fix: 🔍 improve seo * fix: 🔍 update packages --------- Co-authored-by: Habib Deriv <[email protected]> * empty: 🚀 to redeploy and trigger build * fix: alignment issue for the hero block * fix: left crop issue fixed * fix: hotfix * empty: 🚀 to redeploy and trigger build * fix: sync package-lock.json * Mitra/DPROD-3022/Update content for new homepage (binary-com#6895) * text: 📝 update row content * fix: 📝 update eu content * fix: 📝 fix content issue * fix: 💄 add padding * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: 🔍 improve seo title and meta description (binary-com#6881) * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: 📦 update the packages * fix: 🐛 fix change of the icon name coming from quill icons * Mitra/DPROD-3109/Arabic slider scroll issue (binary-com#6963) * fix: 🐛 fix arabic scroll issue in slider * fix: 🐛 fix change of the icon name coming from quill icons * fix: 🐛 fix rtl issue * Mitra/DPROD-3333/Seo alt for svg (binary-com#6929) * fix: 🔍 fix alt for svg * fix: 📦 update packages * empty: 🚀 to redeploy and trigger build * fix: 🐛 fix name of the icons --------- Signed-off-by: hasan-deriv <[email protected]> Co-authored-by: prince-deriv <[email protected]> Co-authored-by: Michio <[email protected]> Co-authored-by: Michio <[email protected]> Co-authored-by: Mohsen Hajibeigloo <[email protected]> Co-authored-by: Habib Deriv <[email protected]> Co-authored-by: DerivFE <[email protected]> Co-authored-by: prince-deriv <[email protected]> Co-authored-by: Hasan Mobarak <[email protected]> Co-authored-by: fasihali-deriv <[email protected]> Co-authored-by: Fasih Ali <[email protected]> Co-authored-by: jia-deriv <[email protected]> Co-authored-by: Aswathy-Deriv <[email protected]> Co-authored-by: Nuzhy-Deriv <[email protected]> Co-authored-by: meenakshi-deriv <[email protected]> Co-authored-by: meenu-deriv <[email protected]> Co-authored-by: jia-deriv <[email protected]> Co-authored-by: fasihali-deriv <[email protected]> Co-authored-by: aswathy-deriv <[email protected]> Co-authored-by: mayuran-deriv <[email protected]> Co-authored-by: meenakshi-deriv <[email protected]>
amir-deriv
pushed a commit
to amir-deriv/deriv-com
that referenced
this pull request
Feb 5, 2024
)" (binary-com#6978) This reverts commit b8ad900.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change