This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
mayuran/FEQ-1291/github_work_flow #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayuran-deriv
requested review from
habib-deriv,
yashim-deriv and
prince-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
…/git_hub_workflow_security_improvements
mayuran-deriv
requested review from
mitra-deriv and
fasihali-deriv
as code owners
hasan-deriv
reviewed
Feb 6, 2024
balakrishna-deriv
approved these changes
Feb 6, 2024
hasan-deriv
approved these changes
Feb 6, 2024
mitra-deriv
previously approved these changes
Feb 6, 2024
aswathy-deriv
previously approved these changes
Feb 6, 2024
habib-deriv
previously approved these changes
Feb 20, 2024
…/git_hub_workflow_security_improvements
mayuran-deriv
dismissed stale reviews from habib-deriv, aswathy-deriv, and mitra-deriv
via
70f5a5f
|
|
Preview Link: https://mayuran-git-hub-work.deriv-com-preview-links.pages.dev
|
|
🚀 Smoke test run (2) passed successfully! |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
🚀 Smoke test run (4) passed successfully! |
|
🚀 Smoke test run (3) passed successfully! |
habib-deriv
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From FE side we'll check these top level permissions() and move them down to job level, wherever it's needed. Additionally update SHA version with commit ID.
Type of change