This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
[FEQ]/Yaswanth/FEQ-1089/To separate docker and k8s notification #6434
Merged
ali-hosseini-deriv
merged 4 commits into
binary-com:master
from
yaswanth-deriv:yaswanth/FEQ-1089_deriv-com-separate-docker-and-k8s-notification
Jan 10, 2024
Merged
[FEQ]/Yaswanth/FEQ-1089/To separate docker and k8s notification #6434
ali-hosseini-deriv
merged 4 commits into
binary-com:master
from
yaswanth-deriv:yaswanth/FEQ-1089_deriv-com-separate-docker-and-k8s-notification
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaswanth-deriv
requested review from
habib-deriv,
yashim-deriv and
prince-deriv
as code owners
January 4, 2024 09:26
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yaswanth-deriv
changed the title
refactor: To separate docker and k8s notification
[FEQ]/Yaswanth/FEQ-1089/To separate docker and k8s notification
Jan 4, 2024
ali-hosseini-deriv
suggested changes
Jan 9, 2024
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
ali-hosseini-deriv
approved these changes
Jan 10, 2024
habib-deriv
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
meenakshi-deriv
pushed a commit
to meenakshi-deriv/deriv-com
that referenced
this pull request
Jan 10, 2024
…ry-com#6434) * refactor: To separate docker and k8s notification * refactor: To remove extra spaces * refactor: To remove extra spaces * refactor: added not success condition in docker slack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change