This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
[CRO] NikitK/CRO-380/tracking issues for partners signup #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitK-deriv
requested review from
habib-deriv,
yashim-deriv,
prince-deriv,
mitra-deriv,
mohsen-deriv and
fasihali-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
dan-deriv
changed the title
dan-deriv
reviewed
Dec 26, 2023
src/pages/signup-affiliates/components/wizard-component/wizard-footer.tsx
Outdated
Show resolved
Hide resolved
dan-deriv
reviewed
Dec 26, 2023
NikitK-deriv
force-pushed
the
cro-partners-signup-fix
branch
from
387ed87 to
534c7d6
Compare
mitra-deriv
reviewed
Jan 3, 2024
habib-deriv
reviewed
Jan 3, 2024
|
@NikitK-deriv |
mitra-deriv
reviewed
Jan 3, 2024
mitra-deriv
previously approved these changes
Jan 3, 2024
NikitK-deriv
force-pushed
the
cro-partners-signup-fix
branch
from
0aabc37 to
9aa8e34
Compare
|
|
Preview Link: https://cro-partners-signup1.deriv-com-preview-links.pages.dev
|
|
🚀 Smoke test run (2) passed successfully! |
|
🚀 Smoke test run (3) passed successfully! |
|
🚀 Smoke test run (4) passed successfully! |
|
🚀 Smoke test run (1) passed successfully! |
aswathy-deriv
approved these changes
Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
In partner signup form we have tracking system for analytic purpose. In that system we have to fix issue with nulls for partners_signup_error_message field and not valid step_codename.
Include default browser API's pop up which handle when user want to close tab/refresh page
Type of change