-
Notifications
You must be signed in to change notification settings - Fork 184
[CRO][Translation] MyAffiliate signup form #5992
[CRO][Translation] MyAffiliate signup form #5992
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
3c1e080
to
0fbe483
Compare
Running Lighthouse audit... |
b849342
to
5dfee8c
Compare
5dfee8c
to
51dfda1
Compare
78379b3
to
f53b848
Compare
🚀 Smoke test run (1) passed successfully! |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 9 New issues |
Preview Link: https://translation-408-myaf.deriv-com-preview-links.pages.dev
|
🚀 Smoke test run (2) passed successfully! |
🚀 Smoke test run (3) passed successfully! |
🚀 Smoke test run (4) passed successfully! |
🚀 Smoke test run (1) passed successfully! |
🚀 Smoke test run (5) passed successfully! |
Changes:
Form for affiliate signup registration
Connected with back-end in onSubmit function
Handle different errors like connection lost, username exist
Have a tracking features and will be release with a/b testing
[TECHNICAL DEBT]:
Developed mostly with styled components so can be refactored with atomic approach in the future
Using common useState instead of react-hook-form so can be refactored as well
validation is not ideal and should be improved using react-hook-forms
we have no updated API for this method so we can see a lot of ts errors here and any in types for that
Type of change