Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

[CRO][Translation] MyAffiliate signup form #5992

Conversation

NikitK-deriv
Copy link
Contributor

@NikitK-deriv NikitK-deriv commented Nov 21, 2023

Changes:

Form for affiliate signup registration
Connected with back-end in onSubmit function
Handle different errors like connection lost, username exist
Have a tracking features and will be release with a/b testing

[TECHNICAL DEBT]:

Developed mostly with styled components so can be refactored with atomic approach in the future
Using common useState instead of react-hook-form so can be refactored as well
validation is not ideal and should be improved using react-hook-forms
we have no updated API for this method so we can see a lot of ts errors here and any in types for that

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-com ✅ Ready (Inspect) Visit Preview Dec 19, 2023 9:14am

Copy link

gitguardian bot commented Nov 29, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

Running Lighthouse audit...

Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
3.9% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Preview Link: https://translation-408-myaf.deriv-com-preview-links.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

🚀 Smoke test run (3) passed successfully!

Copy link
Contributor

🚀 Smoke test run (4) passed successfully!

Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

Copy link
Contributor

🚀 Smoke test run (5) passed successfully!

@fasihali-deriv fasihali-deriv merged commit a1b7c89 into binary-com:master Dec 19, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants