This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
[CRO] MyAffiliate signup form #5923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitK-deriv
force-pushed
the
cellxpert-continue
branch
from
85f75ba to
eda331c
Compare
|
🚀 Smoke test run (4) passed successfully! |
|
Deployment failed with the following error: |
|
SonarCloud Quality Gate failed.
|
|
Preview Link: https://cellxpert-continue.deriv-com-preview-links.pages.dev
|
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |
|
🚀 Smoke test run (5) passed successfully! |
|
🚀 Smoke test run (3) passed successfully! |
|
🚀 Smoke test run (4) passed successfully! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Form for affiliate signup registration
Connected with back-end in onSubmit function
Handle different errors like connection lost, username exist
Have a tracking features
[TECHNICAL DEBT]:
Developed mostly with styled components so can be refactored with atomic approach in the future
Using common useState instead of react-hook-form so can be refactored as well
validation is not ideal and should be improved using react-hook-forms
we have no updated API for this method so we can see a lot of ts errors here and any in types for that
Type of change