Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Aswathy/fix: eslint error to import layout component first #5791

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

aswathy-deriv
Copy link
Contributor

@aswathy-deriv aswathy-deriv commented Oct 18, 2023

Changes:

  • Importing the Layout component before the other child component order rule is set in eslint.

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-com ✅ Ready (Inspect) Visit Preview Oct 18, 2023 11:46am

@github-actions
Copy link
Contributor

Preview Link: https://eslint-order-sort.deriv-com-preview-links.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟠 Accessibility 83
🟢 Best practices 92
🟢 SEO 93
🟢 PWA 90

Lighthouse ran on https://deriv-com-git-fork-aswathy-deriv-eslintordersort.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.4% 5.4% Duplication

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitra-deriv mitra-deriv merged commit 3d9d8a3 into binary-com:master Oct 20, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants