Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Hasan/fix: hero image flickering #5716

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Sep 29, 2023

Changes:

  • Homepage's hero image flickering issue onload

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-com ✅ Ready (Inspect) Visit Preview Oct 5, 2023 9:24am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟠 Accessibility 83
🟢 Best practices 92
🟢 SEO 93
🟢 PWA 90

Lighthouse ran on https://deriv-com-git-fork-hasan-deriv-pr-1958-hero-img-flicker.binary.sx/

Copy link
Contributor

@niloofar-deriv niloofar-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

habib-deriv
habib-deriv previously approved these changes Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Preview Link: https://pr-1958-hero-img-fli.deriv-com-preview-links.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@aswathy-deriv aswathy-deriv merged commit f07b219 into binary-com:master Oct 11, 2023
5 checks passed
habib-deriv added a commit that referenced this pull request Oct 13, 2023
habib-deriv added a commit that referenced this pull request Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants