This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 184
Hasan/fix: hero image flickering #5716
Merged
aswathy-deriv
merged 3 commits into
binary-com:master
from
hasan-deriv:pr-1958-hero-img-flicker
Oct 11, 2023
Merged
Hasan/fix: hero image flickering #5716
aswathy-deriv
merged 3 commits into
binary-com:master
from
hasan-deriv:pr-1958-hero-img-flicker
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan-deriv
requested review from
habib-deriv,
prince-deriv,
mohsen-deriv,
mitra-deriv and
fasihali-deriv
as code owners
September 29, 2023 06:16
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-fork-hasan-deriv-pr-1958-hero-img-flicker.binary.sx/ |
mayuran-deriv
approved these changes
Sep 29, 2023
niloofar-deriv
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
habib-deriv
previously approved these changes
Oct 2, 2023
Kudos, SonarCloud Quality Gate passed! |
Preview Link: https://pr-1958-hero-img-fli.deriv-com-preview-links.pages.dev
|
aswathy-deriv
approved these changes
Oct 11, 2023
habib-deriv
added a commit
that referenced
this pull request
Oct 13, 2023
This reverts commit f07b219.
habib-deriv
added a commit
that referenced
this pull request
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: