-
Notifications
You must be signed in to change notification settings - Fork 185
adrienne / fix branch name formatting for cloudflare pages deployment comment #5683
adrienne / fix branch name formatting for cloudflare pages deployment comment #5683
Conversation
This reverts commit a401298.
…nne-deriv/deriv-com into fix-cloudflare-deployment-security
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Google API Key | 8179b91 | src/common/constants.ts | View secret |
- | Google API Key | 85ad00b | src/common/constants.ts | View secret |
- | Google API Key | 85ad00b | src/common/constants.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-fork-adrienne-deriv-fix-branch-name-cf-deloyment.binary.sx/ |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Preview Link: https://fix-branch-name-cf-deloyment.deriv-com-preview-links.pages.dev
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… comment (binary-com#5683) * refactor: sanitized email input from html element symbols * chore: added pre-flow workflow for cloudflare pages * chore: reverted prettier changes * Revert "chore: reverted prettier changes" This reverts commit a401298. * chore: reverted prettier changes again * chore: reverted pretiter changes againn * Update messages.json * Update messages.json * chore: change secrets name * fix: fixed issues with branch naming
Changes:
Type of change