Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

adrienne / fix branch name formatting for cloudflare pages deployment comment #5683

Merged

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

  • ...

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-com ✅ Ready (Inspect) Visit Preview Sep 26, 2023 4:31am

@gitguardian
Copy link

gitguardian bot commented Sep 26, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Google API Key 8179b91 src/common/constants.ts View secret
- Google API Key 85ad00b src/common/constants.ts View secret
- Google API Key 85ad00b src/common/constants.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟠 Accessibility 83
🟢 Best practices 92
🟢 SEO 93
🟢 PWA 90

Lighthouse ran on https://deriv-com-git-fork-adrienne-deriv-fix-branch-name-cf-deloyment.binary.sx/

@adrienne-deriv adrienne-deriv marked this pull request as ready for review September 26, 2023 04:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@github-actions
Copy link
Contributor

Preview Link: https://fix-branch-name-cf-deloyment.deriv-com-preview-links.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview

Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashim-deriv yashim-deriv merged commit 40725f4 into binary-com:master Sep 26, 2023
4 of 5 checks passed
meenakshi-deriv pushed a commit to meenakshi-deriv/deriv-com that referenced this pull request Oct 4, 2023
… comment (binary-com#5683)

* refactor: sanitized email input from html element symbols

* chore: added pre-flow workflow for cloudflare pages

* chore: reverted prettier changes

* Revert "chore: reverted prettier changes"

This reverts commit a401298.

* chore: reverted prettier changes again

* chore: reverted pretiter changes againn

* Update messages.json

* Update messages.json

* chore: change secrets name

* fix: fixed issues with branch naming
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants