This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
fix: bugs #5676
Merged
fix: bugs #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayuran-deriv
requested review from
habib-deriv,
prince-deriv,
mitra-deriv and
fasihali-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-fork-mayuran-deriv-mayuran-regressionpaddingout.binary.sx/ |
hasan-deriv
approved these changes
Sep 25, 2023
konstantinosG-deriv
approved these changes
Sep 25, 2023
fasihali-deriv
previously approved these changes
Sep 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
aswathy-deriv
approved these changes
Sep 25, 2023
jia-deriv
reviewed
Sep 27, 2023
| @@ -63,7 +63,7 @@ | |||
| gap: 1rem; | |||
|
|
|||
| td { | |||
| padding: 1rem; | |||
| padding-block: 1rem; | |||
There was a problem hiding this comment.
Why is padding-block using here instead of padding: 1rem 0? Is it padding-block better?
There was a problem hiding this comment.
hi @jia-deriv padding bock is different its CSS logical properties,
I had to give padding only for top and bottom so I did this
meenakshi-deriv
pushed a commit
to meenakshi-deriv/deriv-com
that referenced
this pull request
Oct 4, 2023
* fix: bugs * fix: fix padding * fix: remove padding * fix: add padding block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
regression bugs spacing issues
Type of change