This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adrienne / fix cloudflare deployment security #5667
adrienne / fix cloudflare deployment security #5667
Changes from 13 commits
89a6b34
4cb9901
85ad00b
8179b91
cd6cb15
db86c13
780be4e
f631ab4
291507d
a401298
538ebd2
165ee47
d8fd559
202edf7
22fe2f5
b641ca5
2139b0b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a separate Github classic token for this with SSO verification for binary-com organization
cc: @balakrishna-deriv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will secrets.GITHUB_TOKEN work? I think it might work because we are only doing a read operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noo it needs a new token that is SSOed with binary-com organization, the GITHUB_TOKEN is provided by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.