Cellxpert continue #5624

NikitK-deriv · 2023-09-12T13:12:11Z

Changes:

Form for affiliate signup registration
Connected with back-end in onSubmit function
Handle different errors like connection lost, username exist
Have a tracking features

[TECHNICAL DEBT]:

Developed mostly with styled components so can be refactored with atomic approach in the future
Using common useState instead of react-hook-form so can be refactored as well
validation is not ideal and should be improved using react-hook-forms
we have no updated API for this method so we can see a lot of ts errors here and any in types for that

Type of change

vercel · 2023-09-12T13:12:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-com	✅ Ready (Inspect)	Visit Preview	Oct 19, 2023 8:10am

gitguardian · 2023-09-12T13:12:48Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
-	Google API Key	`c691418`	src/common/constants.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

github-actions · 2023-09-12T13:18:27Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	0
🟠 Accessibility	88
🟠 Best practices	83
🟢 SEO	100
🟢 PWA	90

Lighthouse ran on https://deriv-com-git-fork-nikitk-deriv-cellxpert-continue.binary.sx/

github-actions · 2023-10-18T12:57:02Z

🚀 Smoke test run (5) passed successfully!

github-actions · 2023-10-18T12:57:02Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-10-18T12:57:05Z

🚀 Smoke test run (4) passed successfully!

github-actions · 2023-10-18T12:57:08Z

🚀 Smoke test run (3) passed successfully!

github-actions · 2023-10-18T12:57:57Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-10-18T13:13:13Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-10-18T13:13:14Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-10-18T13:13:16Z

🚀 Smoke test run (4) passed successfully!

github-actions · 2023-10-18T13:14:17Z

🚀 Smoke test run (5) passed successfully!

github-actions · 2023-10-19T07:55:58Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-10-19T07:55:58Z

❌ Smoke test run (3) failed. See logs for details: Visit Action

github-actions · 2023-10-19T07:55:59Z

❌ Smoke test run (5) failed. See logs for details: Visit Action

github-actions · 2023-10-19T07:56:54Z

🚀 Smoke test run (3) passed successfully!

github-actions · 2023-10-19T07:57:27Z

🚀 Smoke test run (4) passed successfully!

github-actions · 2023-10-19T07:57:28Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-10-19T07:58:47Z

🚀 Smoke test run (1) passed successfully!

sonarqubecloud · 2023-10-19T08:01:51Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
1 Security Hotspot
5 Code Smells

No Coverage information
3.4% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-actions · 2023-10-19T08:11:29Z

❌ Smoke test run (4) failed. See logs for details: Visit Action

github-actions · 2023-10-19T08:11:30Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-10-19T08:11:31Z

❌ Smoke test run (5) failed. See logs for details: Visit Action

github-actions · 2023-10-19T08:11:34Z

🚀 Smoke test run (3) passed successfully!

github-actions · 2023-10-19T08:54:06Z

Preview Link: https://cellxpert-continue.deriv-com-preview-links.pages.dev

Name	Result
Build status	Completed ✅
Preview URL	Visit Preview
Action URL	Visit Action

NikitK-deriv and others added 17 commits July 13, 2023 11:29

feat: cellxpert registration form

0cd7dbb

chore: console.log for residence_list debug

6a8fd65

fix: send ws

ecb0d3a

fix: add file instead of ws connection

891264b

fix: add file instead of ws connection

1d5a3f1

fix: placement of residence_list

c61e13c

fix: residence_list issue import in vercel

3d7486e

refactor: cosmetic job

51ca54b

chore: change disable for sign up

c43970c

chore: validation job

02e07a9

feat: dinamyc prefix

dd569e6

feat: username + modals

d9cb040

refactor: username

cf28518

chore: make second type unclickable

5aca407

chore: add correct link

ba0f252

feat: add connection between frontend and backedn

d082287

refactor: code-splitting part 1

15bb4d0

NikitK-deriv requested review from habib-deriv, yashim-deriv, prince-deriv, mitra-deriv, fasihali-deriv and mohsen-deriv as code owners September 12, 2023 13:12

vercel bot had a problem deploying to Preview September 12, 2023 13:40 Failure

NikitK-deriv added 2 commits September 13, 2023 11:07

chore: add suspense and make project work with dependencies

5f333a9

refactor: wizard

d2bb168

NikitK-deriv force-pushed the cellxpert-continue branch from 024fffa to d2b64a2 Compare September 13, 2023 08:10

fix: disable insupported character

ae94edf

vercel bot deployed to Preview October 17, 2023 09:16 View deployment

feat: add tracking with local implementation of package

61ced3e

vercel bot deployed to Preview October 18, 2023 13:11 View deployment

NikitK-deriv added 2 commits October 19, 2023 10:16

Merge branch 'master' into cellxpert-continue

0eea6d6

refactor: use package from npm

76b1129

vercel bot deployed to Preview October 19, 2023 08:10 View deployment

prince-deriv closed this Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cellxpert continue #5624

Cellxpert continue #5624

NikitK-deriv commented Sep 12, 2023 •

edited

Loading

vercel bot commented Sep 12, 2023 •

edited

Loading

gitguardian bot commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

sonarqubecloud bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

Cellxpert continue #5624

Cellxpert continue #5624

Conversation

NikitK-deriv commented Sep 12, 2023 • edited Loading

Type of change

vercel bot commented Sep 12, 2023 • edited Loading

gitguardian bot commented Sep 12, 2023 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

github-actions bot commented Sep 12, 2023 • edited Loading

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

sonarqubecloud bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023

NikitK-deriv commented Sep 12, 2023 •

edited

Loading

vercel bot commented Sep 12, 2023 •

edited

Loading

gitguardian bot commented Sep 12, 2023 •

edited

Loading

github-actions bot commented Sep 12, 2023 •

edited

Loading