This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Meenu/Translation 92 page ctrader trade platform #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… translation-92-page-ctrader-trade-platform
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Google API Key | 3703e7f | src/common/constants.ts | View secret |
| - | Google API Key | 4f7ea48 | src/common/constants.ts | View secret |
| - | Google API Key | 3703e7f | src/common/constants.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
added 2 commits
September 7, 2023 08:55
… translation-92-page-ctrader-trade-platform
aswathy-deriv
previously approved these changes
Sep 12, 2023
src/features/components/atoms/tab/tab-content/tab-content.module.scss
Outdated
Show resolved
Hide resolved
src/features/components/templates/navigation/main-nav/content/platform/index.ts
Show resolved
Hide resolved
src/features/pages/deriv-ctrader/trade-description/description.module.scss
Outdated
Show resolved
Hide resolved
src/features/components/templates/trade-platform/other-platforms/platform-card/index.tsx
Outdated
Show resolved
Hide resolved
src/features/components/templates/trade-platform/other-platforms/platform-card/index.tsx
Outdated
Show resolved
Hide resolved
src/features/components/templates/trade-platform/how-to-start/index.tsx
Outdated
Show resolved
Hide resolved
src/features/components/templates/trade-platform/other-platforms/index.tsx
Outdated
Show resolved
Hide resolved
src/features/components/templates/trade-platform/other-platforms/index.tsx
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Preview Link: https://translation-92-page-.deriv-com-preview-links.pages.dev
|
habib-deriv
approved these changes
Sep 28, 2023
meenakshi-deriv
added a commit
to meenakshi-deriv/deriv-com
that referenced
this pull request
Oct 4, 2023
* auto-pull-translation * auto-pull-translation * fix: test * fix: initial commit * fix: product page * fix: banner fixes * fix: products available on added * fix: comments fixes * fix: bug fixes * fix: render issue in mobile in tab * fix: removed ternory and added switch case * auto-pull-translation * fix: added hoc * fix: updated dependency * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: banner issue arab * fix: scss change * fix: empty line removed * feat: created carousel file * feat: added icons * feat: added platform component * Update src/features/components/templates/trade-platform/other-platforms/styles.module.scss Co-authored-by: konstantinosG-deriv <[email protected]> * Update src/features/components/templates/trade-platform/other-platforms/index.tsx Co-authored-by: mayuran-deriv <[email protected]> * fix: pr suggestions * fix: swiper btn's css * fix: radius issue fix * fix: pr comments * fix: integrated other platform section * fix: log mobile or tab * fix: responsive tab fixes * fix: step 2 real image * fix: decrease other platform carousel's speed * fix: align issue in markets * fix: added tab radius and updated urls * fix: added ctrader in available platform * fix: tab button fix * fix: mobile spacing issue * fix: fixed padding * fix: padding fix * fix: ctrader on eu * fix: hidden some ctrader sections and added coming soon tag * fix: review comments * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: added the container fluid * empty: 🚀 to redeploy and trigger build * fix: changes in ctrader page * empty: 🚀 to redeploy and trigger build * empty: 🚀 to redeploy and trigger build * feat: added ctrader in the navigation and footer * fix: changed seo to the main page and added pageContext * fix: peer comments --------- Co-authored-by: meenu-deriv <[email protected]> Co-authored-by: mayuran-deriv-dev96 <[email protected]> Co-authored-by: DerivFE <[email protected]> Co-authored-by: hasan-deriv <[email protected]> Co-authored-by: Hasan Mobarak <[email protected]> Co-authored-by: konstantinosG-deriv <[email protected]> Co-authored-by: mayuran-deriv <[email protected]> Co-authored-by: aswathy-deriv <[email protected]> Co-authored-by: Spare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change