Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Commit

Permalink
Meenu/{DPROD-2331}/Translation 2331 fixx cta button 3 steps (#6496)
Browse files Browse the repository at this point in the history
* fix: fix subtask

* fix: removed wrong commit

* fix: fix changes

* fix: fixed icon

* fix: fixed conflicts

* fix: updated with upstream
  • Loading branch information
meenakshi-deriv authored Jan 11, 2024
1 parent d4ea2bc commit a8460bc
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 4 deletions.
1 change: 1 addition & 0 deletions crowdin/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -3121,6 +3121,7 @@
"-1179918966": "Browser Update Alert",
"-684271315": "OK",
"-1809314981": "Other markets you might be interested in",
"-1255879419": "Trader's Hub",
"-1124845179": "Open demo account",
"-696867299": "Get trading",
"-943701585": "Available on",
Expand Down
2 changes: 1 addition & 1 deletion src/data/trustpilot.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"stars": 4.5,
"trustScore": 4.6,
"numberOfReviews": "37,000"
"numberOfReviews": "39,092"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { ComponentPropsWithRef, forwardRef } from 'react'
import { Button } from '@deriv/quill-design'
import { LabelPairedGrid2LgBoldIcon } from '@deriv/quill-icons'
import useAuthCheck from 'components/hooks/use-auth-check'
import useHandleSignup from 'components/hooks/use-handle-signup'
import { handleRedirectToTradersHub } from 'components/custom/utils'
Expand All @@ -17,11 +18,13 @@ const TradersHubCtaButton = forwardRef<HTMLButtonElement, TradersHubCtaButtonPro
<Button
ref={ref}
size="lg"
icon={LabelPairedGrid2LgBoldIcon}
iconPosition="start"
onClick={handleRedirectToTradersHub}
className={className}
{...rest}
>
<Localize translate_text="_t_Traders Hub_t_" />
<Localize translate_text="_t_Trader's Hub_t_" />
</Button>
)
}
Expand Down
4 changes: 3 additions & 1 deletion src/features/pages/home/cta/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ const CTA = () => {
<Heading.H2 className="text-solid-slate-50">
<Localize translate_text="_t_Join over 2.5 million online traders_t_" />
</Heading.H2>
<TradersHubCtaButton className="hidden lg:block" />
<div className="hidden lg:block">
<TradersHubCtaButton className="flex" />
</div>
</div>
</Footer.CTABlock>
)
Expand Down
6 changes: 5 additions & 1 deletion src/features/pages/home/start-trading-steps/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ const StartTradingSteps = () => {
<Features.Card
className="xl:[&>*:nth-child(1)]:!px-50"
title={<Localize translate_text="_t_Start trading in 3 simple steps_t_" />}
cta={<TradersHubCtaButton className="hidden lg:block" />}
cta={
<div className="hidden lg:block">
<TradersHubCtaButton className="flex" />
</div>
}
cols="three"
variant="ContentTop"
cards={is_eu ? EUCards : RowCards}
Expand Down
1 change: 1 addition & 0 deletions src/pages/home/_translations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,5 @@ export const translation_strings = [
'_t_60+ global payment methods. Deposit instantly starting from just USD 5. Withdraw in minutes.*_t_',
'_t_* Availability of payment methods and processing speeds may vary based on location and selected payment option_t_',
'_t_Trade CFDs & Multipliers_t_',
"_t_Trader's Hub_t_",
]

0 comments on commit a8460bc

Please sign in to comment.