Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Change the button content on successful registration to redirect to telegram channel #255

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Change the button content on successful registration to redirect to telegram channel #255

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7172dd8
chore: changed registration flow
sanjam-deriv Oct 23, 2023
c6db2c8
chore: test fix
sanjam-deriv Oct 23, 2023
c4628a7
chore: design fix
sanjam-deriv Oct 25, 2023
f3018d7
chore: test fix
sanjam-deriv Oct 25, 2023
127d70a
chore: design fix
sanjam-deriv Oct 25, 2023
5eb8e41
chore: design fix
sanjam-deriv Oct 25, 2023
0047454
chore: responsive design fix
sanjam-deriv Oct 26, 2023
e33fd25
chore: responsive font size
sanjam-deriv Oct 26, 2023
8079633
chore: link fix
sanjam-deriv Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...omponents/Dialogs/RegisterAppDialogSuccess/__tests__/register-app-dialog-success.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('App Dialog Register Success', () => {
});

it('Should render buttons properly', () => {
const primaryButton = screen.getByRole('button', { name: /manage application/i });
const primaryButton = screen.getByRole('button', { name: /join our telegram community/i });
const secondaryButton = screen.getByRole('button', { name: /got it/i });

expect(primaryButton).toBeInTheDocument();
Expand All @@ -52,7 +52,7 @@ describe('App Dialog Register Success', () => {
});

it('Should update current tab on primary button click to Manage Application', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the test description as well? Thanks

const primaryButton = screen.getByRole('button', { name: /manage application/i });
const primaryButton = screen.getByRole('button', { name: /join our telegram community/i });

await userEvent.click(primaryButton);

Expand Down
3 changes: 2 additions & 1 deletion src/features/dashboard/components/Dialogs/RegisterAppDialogSuccess/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ export const RegisterAppDialogSuccess = ({ onClose }: IRegisterAppDialogSuccessP
() => [
{
id: 0,
text: 'Manage application',
text: 'Join our Telegram Community',
color: 'primary',
onClick: () => {
updateCurrentTab('MANAGE_APPS');
window.open('https://t.me/deriv_apps', '_blank');
onClose();
},
},
Expand Down