Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIM-30184 - added arrow icons #110

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

BIM-30184 - added arrow icons #110

wants to merge 4 commits into from

Conversation

verych
Copy link

@verych verych commented Jun 28, 2023

No description provided.

wndffs
wndffs reviewed Jun 28, 2023
View reviewed changes
projects/icons/src/declarations/constants/icons/app-arrow-down.ts Outdated
Comment on lines 6 to 10
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<g id="arrow-down">
<path id="vector" d="M3.14645 9.3535C2.95118 9.15824 2.95118 8.84166 3.14645 8.6464C3.34171 8.45113 3.65829 8.45114 3.85355 8.6464L7.49996 12.2928L7.49996 2.49996C7.49996 2.22382 7.72382 1.99996 7.99996 1.99996C8.2761 1.99996 8.49996 2.22382 8.49996 2.49996L8.49996 12.2929L12.1464 8.64642C12.3416 8.45115 12.6582 8.45115 12.8535 8.64641C13.0487 8.84167 13.0487 9.15826 12.8535 9.35352L8.35354 13.8535C8.33984 13.8672 8.32542 13.88 8.31037 13.892C8.22739 13.9578 8.12304 13.9978 8.00942 13.9999C8.00628 13.9999 8.00313 14 7.99999 14C7.99787 14 7.99576 13.9999 7.99364 13.9999C7.85658 13.9982 7.7328 13.9414 7.64347 13.8505L3.14645 9.3535Z" fill="currentColor"/>
</g>
</svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

зачем группа и айдишники, неверно скопирована иконка

Suggested change
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<g id="arrow-down">
<path id="vector" d="M3.14645 9.3535C2.95118 9.15824 2.95118 8.84166 3.14645 8.6464C3.34171 8.45113 3.65829 8.45114 3.85355 8.6464L7.49996 12.2928L7.49996 2.49996C7.49996 2.22382 7.72382 1.99996 7.99996 1.99996C8.2761 1.99996 8.49996 2.22382 8.49996 2.49996L8.49996 12.2929L12.1464 8.64642C12.3416 8.45115 12.6582 8.45115 12.8535 8.64641C13.0487 8.84167 13.0487 9.15826 12.8535 9.35352L8.35354 13.8535C8.33984 13.8672 8.32542 13.88 8.31037 13.892C8.22739 13.9578 8.12304 13.9978 8.00942 13.9999C8.00628 13.9999 8.00313 14 7.99999 14C7.99787 14 7.99576 13.9999 7.99364 13.9999C7.85658 13.9982 7.7328 13.9414 7.64347 13.8505L3.14645 9.3535Z" fill="currentColor"/>
</g>
</svg>
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M3.14648 9.35348C2.95121 9.15822 2.95122 8.84164 3.14648 8.64637C3.34174 8.45111 3.65832 8.45111 3.85358 8.64638L7.49999 12.2928L7.49999 2.49994C7.49999 2.22379 7.72385 1.99994 7.99999 1.99994C8.27613 1.99994 8.49999 2.22379 8.49999 2.49994L8.49999 12.2928L12.1464 8.64639C12.3417 8.45113 12.6582 8.45113 12.8535 8.64639C13.0488 8.84165 13.0488 9.15823 12.8535 9.3535L8.35357 13.8535C8.33987 13.8672 8.32545 13.88 8.3104 13.8919C8.22742 13.9577 8.12307 13.9977 8.00945 13.9999C8.00631 13.9999 8.00317 13.9999 8.00002 13.9999C7.9979 13.9999 7.99579 13.9999 7.99367 13.9999C7.85661 13.9982 7.73283 13.9414 7.6435 13.8505L3.14648 9.35348Z" fill="#1C1D22"/>
</svg>

wndffs
wndffs reviewed Jun 28, 2023
View reviewed changes
projects/icons/src/declarations/constants/icons/app-arrow-down.ts Outdated
@@ -0,0 +1,12 @@
import { IconDefinition } from '../../interfaces/icon-definition.interface';

export const appArrowDown: IconDefinition = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • имя файла
Suggested change
export const appArrowDown: IconDefinition = {
export const appArrowDownIcon: IconDefinition = {

wndffs
wndffs reviewed Jun 28, 2023
View reviewed changes
projects/icons/src/declarations/constants/icons/app-arrow-up.ts Outdated
Comment on lines 6 to 10
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<g id="arrow-up">
<path id="Union" d="M12.8536 6.64646C13.0488 6.84172 13.0488 7.1583 12.8536 7.35357C12.6583 7.54883 12.3417 7.54883 12.1464 7.35356L8.50004 3.70714L8.50004 13.5C8.50004 13.7761 8.27618 14 8.00004 14C7.7239 14 7.50004 13.7761 7.50004 13.5L7.50004 3.70709L3.85363 7.35354C3.65837 7.54881 3.34179 7.54881 3.14653 7.35355C2.95126 7.15829 2.95126 6.84171 3.14652 6.64644L7.64646 2.14645C7.66016 2.13274 7.67458 2.11991 7.68963 2.108C7.77261 2.0422 7.87696 2.0022 7.99058 2.00009C7.99372 2.00003 7.99687 2 8.00001 2C8.00213 2 8.00424 2.00001 8.00636 2.00004C8.14342 2.00174 8.2672 2.05859 8.35653 2.14941L12.8536 6.64646Z" fill="currentColor"/>
</g>
</svg>
Copy link
Member

@wndffs wndffs Jun 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут тоже

Suggested change
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<g id="arrow-up">
<path id="Union" d="M12.8536 6.64646C13.0488 6.84172 13.0488 7.1583 12.8536 7.35357C12.6583 7.54883 12.3417 7.54883 12.1464 7.35356L8.50004 3.70714L8.50004 13.5C8.50004 13.7761 8.27618 14 8.00004 14C7.7239 14 7.50004 13.7761 7.50004 13.5L7.50004 3.70709L3.85363 7.35354C3.65837 7.54881 3.34179 7.54881 3.14653 7.35355C2.95126 7.15829 2.95126 6.84171 3.14652 6.64644L7.64646 2.14645C7.66016 2.13274 7.67458 2.11991 7.68963 2.108C7.77261 2.0422 7.87696 2.0022 7.99058 2.00009C7.99372 2.00003 7.99687 2 8.00001 2C8.00213 2 8.00424 2.00001 8.00636 2.00004C8.14342 2.00174 8.2672 2.05859 8.35653 2.14941L12.8536 6.64646Z" fill="currentColor"/>
</g>
</svg>
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M12.8535 6.64646C13.0488 6.84172 13.0488 7.1583 12.8535 7.35357C12.6583 7.54883 12.3417 7.54883 12.1464 7.35356L8.50001 3.70714L8.50001 13.5C8.50001 13.7761 8.27615 14 8.00001 14C7.72386 14 7.50001 13.7761 7.50001 13.5L7.50001 3.70709L3.8536 7.35354C3.65834 7.54881 3.34176 7.54881 3.1465 7.35355C2.95123 7.15829 2.95123 6.84171 3.14649 6.64644L7.64643 2.14645C7.66013 2.13274 7.67455 2.11991 7.6896 2.108C7.77258 2.0422 7.87693 2.0022 7.99055 2.00009C7.99369 2.00003 7.99683 2 7.99998 2C8.0021 2 8.00421 2.00001 8.00633 2.00004C8.14339 2.00174 8.26717 2.05859 8.3565 2.14941L12.8535 6.64646Z" fill="currentColor"/>
</svg>

wndffs
wndffs reviewed Jun 28, 2023
View reviewed changes
projects/icons/src/declarations/constants/icons/app-arrow-up.ts Outdated
@@ -0,0 +1,12 @@
import { IconDefinition } from '../../interfaces/icon-definition.interface';

export const appArrowUp: IconDefinition = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • имя файла
Suggested change
export const appArrowUp: IconDefinition = {
export const appArrowUpIcon: IconDefinition = {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wndffs wndffs wndffs left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verych @wndffs