Shutdown unix streams before dropping #237
Conversation
|
cc @SeaDve this fixes the issue in Bustle 0.9. |
Interesting. Still, there's probably an issue somewhere, causing bustle/zbus to freeze but not bustle/dbus-monitor. |
|
I think shutdown will write the eof byte and we might be just waiting forever if it was not set. What i dont follow is that close should implicitly call shutdown. |
src/desktop/secret.rs
Outdated
| let mut x1 = { | ||
| let (x1, x2) = UnixStream::pair()?; | ||
| proxy.retrieve(&x2).await?; | ||
| x2.shutdown(Shutdown::Both)?; |
There was a problem hiding this comment.
Afaik, there is no need to close both halves, closing the writing half should suffice.
|
@SeaDve @bilelmoussaoui Could you please verify that this actually fixes the issue? The reproducer is to call the retrieve method while bustle 0.9 (note that flathub is at 0.10) is recording the session bus. |
I have it on my todo list. will try to have a look the upcoming days |
Fixes an issue where recording with bustle would block ashpd's retrieve secret method.
This is more general. Since BorrowedFd implements AsFd this should not really break users.
gnome-keyring will always pass 64 bytes so we allocated only once. If other implementations require: - less: Then we still allocate fewer times, and extra bytes do not harm - more: Then we still allocate fewer times than before
A6GibKm
changed the title
|
Can confirm that this fixes the issues when tested with ASHPD demo (async-std) and Bustle on the commit before migrating to dbus-monitor and without this MR it does not work. |
No description provided.