Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop/game_mode: Use i32 for pid #234

Merged
merged 4 commits into from
Sep 15, 2024
Merged

desktop/game_mode: Use i32 for pid #234

merged 4 commits into from
Sep 15, 2024

Commits on Sep 15, 2024

  1. lib: Add Pid type 

    The Pid type alias ensures that the proper type is used for pids (u32),
which is the same as used by std.
    @kjarosh
    kjarosh committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    62aacea View commit details
    Browse the repository at this point in the history

  2. desktop/game_mode: Use i32 for pid 

    As per the documentation, methods which accept pids (e.g. RegisterGame,
RegisterGameByPid) require the type of pid to be i (i32), not u (u32).

Using u32 causes errors in runtime, making these methods unusable.
This bug was most likely introduced by ae81250.
    @kjarosh
    kjarosh committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    3736863 View commit details
    Browse the repository at this point in the history

  3. desktop/device: Use Pid type for pids

    @kjarosh
    kjarosh committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    87f712a View commit details
    Browse the repository at this point in the history

  4. flatpak: Use Pid type for pids

    @kjarosh
    kjarosh committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    536110a View commit details
    Browse the repository at this point in the history