Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options #165

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Conversation

A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Sep 2, 2023

No description provided.

src/desktop/email.rs Outdated Show resolved Hide resolved
@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 2, 2023

The print portal commit was marked as wip since this won't be exposed to the user, probably the prepare_print fn should be set to use a builder pattern otherwise it has too many optional arguments.

@bilelmoussaoui
Copy link
Owner

The print portal commit was marked as wip since this won't be exposed to the user, probably the prepare_print fn should be set to use a builder pattern otherwise it has too many optional arguments.

I didn't spend time to make the print portal using builder pattern because it is too much.

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 2, 2023

The print portal commit was marked as wip since this won't be exposed to the user, probably the prepare_print fn should be set to use a builder pattern otherwise it has too many optional arguments.

I didn't spend time to make the print portal using builder pattern because it is too much.

So just add a new argument?

@bilelmoussaoui
Copy link
Owner

The print portal commit was marked as wip since this won't be exposed to the user, probably the prepare_print fn should be set to use a builder pattern otherwise it has too many optional arguments.

I didn't spend time to make the print portal using builder pattern because it is too much.

So just add a new argument?

For now yes

@A6GibKm A6GibKm force-pushed the mapping_id branch 2 times, most recently from a8a97d6 to aa23df4 Compare September 2, 2023 11:17
@bilelmoussaoui
Copy link
Owner

Could you drop the WIP from the last commit ? Otherwise lgtm

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 2, 2023

flatpak/xdg-desktop-portal#1094 hasn't been merged yet so...

@bilelmoussaoui bilelmoussaoui merged commit 67bd09a into bilelmoussaoui:master Sep 2, 2023
6 checks passed
@bilelmoussaoui bilelmoussaoui deleted the mapping_id branch September 2, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants