Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioned methods #163

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Aug 29, 2023

We throw an error on our side when an interface is called from our side with the wrong version.

TODO

  • One should add documentation to the methods requiring a newer version.
  • Cache the version property

src/proxy.rs Outdated Show resolved Hide resolved
@A6GibKm A6GibKm force-pushed the add-versioned-methods branch from ab76ad0 to 7f5dfcf Compare September 2, 2023 08:46
src/proxy.rs Outdated Show resolved Hide resolved
src/proxy.rs Outdated Show resolved Hide resolved
@A6GibKm A6GibKm force-pushed the add-versioned-methods branch 6 times, most recently from e590f34 to 83769d9 Compare September 2, 2023 19:56
We throw an error on our side when an interface is called from our side
with the wrong version.
@A6GibKm A6GibKm force-pushed the add-versioned-methods branch from 83769d9 to 1022f8b Compare September 2, 2023 20:02
@bilelmoussaoui bilelmoussaoui merged commit 35cb22d into bilelmoussaoui:master Oct 7, 2023
2 of 6 checks passed
@bilelmoussaoui bilelmoussaoui deleted the add-versioned-methods branch October 7, 2023 08:39
bilelmoussaoui added a commit that referenced this pull request Oct 13, 2023
We throw an error on our side when an interface is called from our side
with the wrong version.

Co-authored-by: Bilal Elmoussaoui <[email protected]>
bilelmoussaoui added a commit that referenced this pull request Oct 13, 2023
We throw an error on our side when an interface is called from our side
with the wrong version.

Co-authored-by: Bilal Elmoussaoui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants