Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Add support for accent-color #162

Merged
merged 4 commits into from
Sep 2, 2023

Conversation

A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Aug 29, 2023

No description provided.

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Aug 29, 2023

The biggest change on Color was the addition of the From<OwnedValue> otherwise

error[E0277]: the trait bound `color::Color: From<OwnedValue>` is not satisfied
   --> src/desktop/settings.rs:178:14
    |
178 |         self.read::<Color>(APPEARANCE_NAMESPACE, ACCENT_COLOR_SCHEME_KEY)
    |              ^^^^ the trait `From<OwnedValue>` is not implemented for `color::Color`
    |
    = note: required for `OwnedValue` to implement `Into<color::Color>`
    = note: required for `color::Color` to implement `TryFrom<OwnedValue>`

For more information about this error, try `rustc --explain E0277`.
warning: `ashpd` (lib) generated 2 warnings

src/color.rs Outdated Show resolved Hide resolved
src/color.rs Outdated Show resolved Hide resolved
src/desktop/settings.rs Show resolved Hide resolved
@A6GibKm A6GibKm force-pushed the accent-color branch 3 times, most recently from 80fa9d8 to 3c10c3d Compare September 2, 2023 11:02
src/color.rs Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui merged commit 24970fd into bilelmoussaoui:master Sep 2, 2023
6 checks passed
@bilelmoussaoui
Copy link
Owner

Thank you

@bilelmoussaoui bilelmoussaoui deleted the accent-color branch September 2, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants